Bug 193735
Summary: | The patch file `linux-2.6-build-nonintconfig.patch' could use some cleanup | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Jiri TRAVNICEK, alias JITR {temporarily not reading bugmail} <travnicj-priv> | ||||
Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||
Status: | CLOSED NOTABUG | QA Contact: | Brian Brock <bbrock> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | wtogami | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-06-23 02:58:19 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Jiri TRAVNICEK, alias JITR {temporarily not reading bugmail}
2006-05-31 22:43:58 UTC
Created attachment 130319 [details]
a proposed updated version of the `linux-2.6-build-nonintconfig.patch' patch
Well, a little misnomer has slipped htough (which is hopefully obvious, but I'd still rather made it clear): The above `Summary as incremental diff ...' ain't a diff of a diff but a diff of the source tree, in particular the one with old version of the patch to the one with the proposed version. Well, I also noticed the removed `break' statements change the semantics of configuration file parsing, e. g. when there are duplicate occurences of the same option and such. I think I know why this was done, but could someone explain this officially? Also what is the exact purpose of return value from `make nonint_oldconfig' (or, in particular from the `main()' function of the `conf' utility) which was added buy this patch? I know what it's value does indicate but would like to know what is it used for? And last, how do you at Red Hat twiddle the configuration files in SRPMs so that the return value is zero? Is there some automated process for this? I find it impossible to do this by hand when a new kernel version is being put in place. Any information or pointers to it would be welcome (and probably not only by me). the breaks are removed so it doesnt abort after the first symbol, so you get a list of symbols that need attention when it fails. There are two separate styles of break removal because the last one has a different intent. (Though for the life of me I can't remember what it was). From time to time, the conf_warning changes get //'s prepended to them to quieten the noise, so they're meant to be in the diff. Other than that, it works as expected, so I'm reluctant to change this, especially as in the past it's been quite fragile. |