Bug 1937827

Summary:	TPM device cannot be marked to be added to VM while it is running
Product:	[oVirt] ovirt-engine	Reporter:	Tamir <tamir>
Component:	BLL.Virt	Assignee:	Milan Zamazal <mzamazal>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Tamir <tamir>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4.5.7	CC:	ahadas, bugs, chhu, juzhou, yanqzhan
Target Milestone:	ovirt-4.4.6	Flags:	pm-rhel: ovirt-4.4+
Target Release:	4.4.6.3
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-engine-4.4.6.3	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-05-05 05:35:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tamir 2021-03-11 15:57:16 UTC

Description of problem:

While a VM with bios type UEFI is running, enabling TPM (using the checkbox in the edit VM modal and pressing OK) isn't possible. After pressing the OK button, and restarting the VM, the TPM device won't be attached to the VM.

Version-Release number of selected component (if applicable):
- Engine instance with RHV 4.4.5-7 (ovirt-engine-4.4.5.7-0.1.el8ev) and RHEL 8.3 installed.
- 3 hosts with RHV 4.4.5-7 and RHEL 8.3, 3 hosts with vdsm-4.40.50.7-1.el8ev

How reproducible:
100%

Steps to Reproduce:

In Admin Portal:

1. Create a 4.5 data center and a 4.5 cluster.
2. Install the host and create a new NFS storage domain.
3. Create a VM with disk and bios type UEFI and without TPM enabled.
4. Run the VM.
5. Open the "Edit Virtual Machine" modal.
6. Enable the TPM checkbox in the "Resource Allocation" tab and press "OK"
7. Restart the VM.
8. Check that the TPM device was added to the VM devices tab in the VM's page.
9. Check that the TPM checkbox in the "Resource Allocation" tab in the "Edit Virtual Machine" modal is still enabled.

Actual results:
1. The 4.5 data center and the 4.5 cluster were created.
2. The host was installed and the NFS storage domain was created.
3. The VM was created.
4. The VM is running.
5. The modal is open.
6. The TPM was enabled in the modal.
7. The VM is UP again (After it was Down).
8. The VM Device wasn't displayed in the VM devices tab in the VM's page.
9. The TPM checkbox wasn't checked in the "Resource Allocation" tab in the "Edit Virtual Machine" modal.

Expected results:
1-7 steps are as expected.
8. The TPM device should be listed in the VM devices tab in the VM's page.
9. The TPM checkbox in the "Resource Allocation" tab in the "Edit Virtual Machine" modal should be checked.

Comment 1 Arik 2021-03-14 09:35:17 UTC

The TPM device is probably not written to the OVF - would be handled when adding TPM to snapshots

Comment 2 Arik 2021-04-12 13:30:16 UTC

*** Bug 1948554 has been marked as a duplicate of this bug. ***

Comment 3 Tamir 2021-04-13 12:51:06 UTC

Verified on RHV 4.4.6-4. All looks good to me.

Env:
  - Engine instance with RHV 4.4.6-4 (ovirt-engine-4.4.6.3-0.8.el8ev) and RHEL 8.4 installed.
  - 3 hosts with RHV 4.4.6-4 and RHEL 8.4, vdsm-4.40.60.3-1.el8ev

Steps:

In Admin Portal:

1. Create a 4.5 data center and a 4.5 cluster.
2. Install the host and create a new NFS storage domain.
3. Create a VM with disk and bios type UEFI and without TPM enabled.
4. Run the VM.
5. Open the "Edit Virtual Machine" modal.
6. Enable the TPM checkbox in the "Resource Allocation" tab and press "OK"
7. Restart the VM.
8. Check that the TPM device was added to the VM devices tab in the VM's page.
9. Check that the TPM checkbox in the "Resource Allocation" tab in the "Edit Virtual Machine" modal is still enabled.

Results (As Expected):

1. The 4.5 data center and the 4.5 cluster were created.
2. The host was installed and the NFS storage domain was created.
3. The VM was created.
4. The VM is running.
5. The modal is open.
6. The TPM was enabled in the modal.
7. The VM is UP again (After it was Down).
8. The VM Device was displayed in the VM devices tab in the VM's page.
9. The TPM checkbox was checked in the "Resource Allocation" tab in the "Edit Virtual Machine" modal.

Comment 4 Sandro Bonazzola 2021-05-05 05:35:57 UTC

This bugzilla is included in oVirt 4.4.6 release, published on May 4th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.6 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.