Bug 193806
Summary: | Review Request: libsvg | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Eric Work <work.eric> |
Component: | Package Review | Assignee: | Michael Schwendt <bugs.michael> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-17 02:35:52 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779, 193807 |
Description
Eric Work
2006-06-01 18:47:08 UTC
Your GPG key 0x6ee49286 cannot be found on pgp.mit.edu and keyserver.net (home pages: http://pgp.mit.edu/ and http://www.keyserver.net ) Thanks for letting me know, I will look into that. For the time being it can be found at http://www.ece.ucdavis.edu/~ewwork/repo/RPM-GPG-KEY-ework. I have put my key onto those two sites. Let me know if you have any changes that should be done to the SPEC file. > checking for pkg-config... no Missing 'BuildRequires: pkgconfig' > BuildRequires: libpng-devel, libjpeg-devel, libxml2-devel, zlib-devel >>> > %package devel >>> > Requires: libpng-devel, libjpeg-devel, libxml2-devel, zlib-devel Oh, it uses libjpeg and libpng headers, but doesn't link to the libs. I suggest you mention that as a comment in the .spec file, as libsvg users must link to these libs then (cf. pkg-config file dependencies!). In this case, "Requires: pkgconfig" is a MUST for the -devel package. File 'INSTALL' in %doc is of no interest to package users. Don't include it. $ cat libsvg-0.1.4.tar.gz.md5 ce0715e3013f78506795fba16e8455d3 libsvg-0.1.4.tar.gz With those minor changes: APPROVED |