Bug 1938212

Summary: Manila share network not showing at Horizon when using the character "-" into the name of the share type
Product: Red Hat OpenStack Reporter: Andre <afariasa>
Component: openstack-manila-uiAssignee: Goutham Pacha Ravi <gouthamr>
Status: CLOSED ERRATA QA Contact: vhariria
Severity: high Docs Contact:
Priority: high    
Version: 16.1 (Train)CC: apevec, astupnik, gouthamr, gregraka, hguemar, lhh, mgarciac, mzheng, ndeevy, slinaber, tbarron, vhariria, vimartin
Target Milestone: z7Keywords: Triaged
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-manila-ui-2.19.3-1.20210626013321.aad56b7.el8ost Doc Type: Bug Fix
Doc Text:
Before this update, the Shared File Systems service (manila) dashboard had dynamic form elements whose names could potentially cause the forms to become unresponsive. This meant that the creation of share groups, share networks, and shares within share networks did not function. + With this update, dynamic elements whose names might be problematic are encoded. Which means that creation of share groups, share networks, and shares within share networks functions normally.
Story Points: ---
Clone Of:
: 1974979 (view as bug list) Environment:
Last Closed: 2021-12-09 20:18:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andre 2021-03-12 13:38:02 UTC
Description of problem:
Share network is not displayed for selection when creating a share with Horizon.
The problem is caused by the character "-" into the name of the share type.

Manila CLI works fine, no issue there.

Do we have any workaround for this issue? Can we rename manila share network?

All logs on the supportshell under /cases/02889416

Version-Release number of selected component (if applicable):
openstack-manila-share:16.1
openstack-manila-scheduler:16.1
openstack-manila-api:16.1
trilio-horizon-plugin:4.1.94-rhosp16.1

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 Tom Barron 2021-03-16 19:31:58 UTC
(In reply to Andre from comment #0)
> Description of problem:
> Share network is not displayed for selection when creating a share with
> Horizon.
> The problem is caused by the character "-" into the name of the share type.
> 
> Manila CLI works fine, no issue there.
> 
> Do we have any workaround for this issue? Can we rename manila share network?

Reading the further details, it seems that the workaround would be to rename the share-type so it doesn't have hyphens rather than the share-network?

In any case, both should work from the CLI and may enable the UI to work until the UI itself is fixed to work properly with hyphenated names.

Example:

(overcloud) [stack@undercloud-0 ~]$ manila type-list
+--------------------------------------+------+------------+------------+-------------------------------------+----------------------+-------------+
| ID                                   | Name | visibility | is_default | required_extra_specs                | optional_extra_specs | Description |
+--------------------------------------+------+------------+------------+-------------------------------------+----------------------+-------------+
| 1ebe411c-8abc-4def-a156-67dfc8557e73 | T-1  | public     | -          | driver_handles_share_servers : True |                      | None        |
+--------------------------------------+------+------------+------------+-------------------------------------+----------------------+-------------+
(overcloud) [stack@undercloud-0 ~]$ manila type-update 1ebe411c-8abc-4def-a156-67dfc8557e73 --name T1
+----------------------+--------------------------------------+
| Property             | Value                                |
+----------------------+--------------------------------------+
| ID                   | 1ebe411c-8abc-4def-a156-67dfc8557e73 |
| Name                 | T1                                   |
| Visibility           | public                               |
| is_default           | -                                    |
| required_extra_specs | driver_handles_share_servers : True  |
| optional_extra_specs |                                      |
| Description          | None                                 |
+----------------------+--------------------------------------+
(overcloud) [stack@undercloud-0 ~]$ manila type-list
+--------------------------------------+------+------------+------------+-------------------------------------+----------------------+-------------+
| ID                                   | Name | visibility | is_default | required_extra_specs                | optional_extra_specs | Description |
+--------------------------------------+------+------------+------------+-------------------------------------+----------------------+-------------+
| 1ebe411c-8abc-4def-a156-67dfc8557e73 | T1   | public     | -          | driver_handles_share_servers : True |                      | None        |
+--------------------------------------+------+------------+------------+-------------------------------------+----------------------+-------------+
(overcloud) [stack@undercloud-0 ~]$ manila share-network-list
+--------------------------------------+------+
| id                                   | name |
+--------------------------------------+------+
| 9f126bf0-9e91-4860-baee-dcec297bb9e9 | SN-1 |
+--------------------------------------+------+
(overcloud) [stack@undercloud-0 ~]$ manila share-network-update --name SN1 9f126bf0-9e91-4860-baee-dcec297bb9e9
+-----------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| Property              | Value                                                                                                                                                                                                                                                                                                         |
+-----------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| id                    | 9f126bf0-9e91-4860-baee-dcec297bb9e9                                                                                                                                                                                                                                                                          |
| name                  | SN1                                                                                                                                                                                                                                                                                                           |
| project_id            | 10979dd58f164381a50f3716cc864513                                                                                                                                                                                                                                                                              |
| created_at            | 2021-03-16T19:29:19.000000                                                                                                                                                                                                                                                                                    |
| updated_at            | 2021-03-16T19:30:26.761841                                                                                                                                                                                                                                                                                    |
| description           | None                                                                                                                                                                                                                                                                                                          |
| share_network_subnets | [{'id': 'b9942982-6d76-4607-bce2-b103f729bdcd', 'availability_zone': None, 'created_at': '2021-03-16T19:29:19.000000', 'updated_at': None, 'segmentation_id': None, 'neutron_net_id': None, 'neutron_subnet_id': None, 'ip_version': None, 'cidr': None, 'network_type': None, 'mtu': None, 'gateway': None}] |
+-----------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
(overcloud) [stack@undercloud-0 ~]$ manila share-network-list
+--------------------------------------+------+
| id                                   | name |
+--------------------------------------+------+
| 9f126bf0-9e91-4860-baee-dcec297bb9e9 | SN1  |
+--------------------------------------+------+

Comment 33 Goutham Pacha Ravi 2021-06-15 21:48:46 UTC
Fix is submitted upstream, will go through code review and get patched downstream when it gets accepted upstream. Will keep this bug updated through the process.

Comment 34 Goutham Pacha Ravi 2021-06-22 21:49:24 UTC
This bug has been cloned into a 16.2 issue: https://bugzilla.redhat.com/show_bug.cgi?id=1974979 since the problem exists on that release stream as well.

Comment 35 Goutham Pacha Ravi 2021-06-23 00:15:35 UTC
*** Bug 1950643 has been marked as a duplicate of this bug. ***

Comment 60 errata-xmlrpc 2021-12-09 20:18:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.7 (Train) bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3762