Bug 1938241

Summary: [SSP] Pod placement configuration - dry run is not performed for all the configuration stanza
Product: Container Native Virtualization (CNV) Reporter: Satyajit Bulage <sbulage>
Component: SSPAssignee: Omer Yahud <oyahud>
Status: CLOSED ERRATA QA Contact: Sarah Bennert <sbennert>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.8.0CC: cnv-qe-bugs, ipinto
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: kubevirt-ssp-operator-container-v4.8.0-17 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 14:28:41 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Incorrect infra configuration. none

Description Satyajit Bulage 2021-03-12 15:10:28 UTC 
Created attachment 1762966 [details]
Incorrect infra configuration.

Description of problem:
Incorrect information related to infra configuration provided to SSP CR through the HCO spec is being accepted.


Version-Release number of selected component (if applicable):4.8


How reproducible:100%


Steps to Reproduce:
1.Add attached yaml contents in the HCO CR spec
2.Observe the HCO CR status in the UI as well as CLI


Actual results: Changes to HCO CR are propagated to SSP CR which is accepted which leads to HCO CR keeping itself in Progressing state and never completes.


Expected results: Changes made to the Infra under HCO CR spec should be refused by SSP CR as they are incorrect.


Additional info:In the attached example the wrong part of the configuration is the "Equal" operand which doesn't exists.

HCO CR refuse to update incorrect changes which is fixed in the BZ(https://bugzilla.redhat.com/show_bug.cgi?id=1893646).
Comment 1 Sarah Bennert 2021-05-10 12:12:31 UTC 
# Openshift cluster
4.8.0-fc.2

# HCO Operator
$ oc -n openshift-cnv get deploy hco-operator -oyaml
        image: registry.redhat.io/container-native-virtualization/hyperconverged-cluster-operator@sha256:7a233fab66fe0e38258ab2876cbb2a8394fae9a9f108f724cc92bc76b9a56c91

hyperconverged-cluster-operator-container-v4.8.0-46

# SSP Operator
$ oc -n openshift-cnv get deploy ssp-operator -oyaml
        image: registry.redhat.io/container-native-virtualization/kubevirt-ssp-operator@sha256:2a97a915503dafbe583bfe5a202ab39f72acb32f69dc094a8aa78845971e1f2d

kubevirt-ssp-operator-container-v4.8.0-27


$ oc -n openshift-cnv patch HyperConverged kubevirt-hyperconverged --type merge -p "$(cat bz1938241-wrong_pod_placement_config.yaml)"
The Deployment "ssp-webhook-placement-verification-deployment" is invalid: spec.template.spec.affinity.nodeAffinity.requiredDuringSchedulingIgnoredDuringExecution.nodeSelectorTerms[0].matchExpressions[0].operator: Invalid value: "Equal": not a valid selector operator


Verified.
Patch was immediately rejected.
No changes to the HCO CR were made, nor did it enter an invalid state.
Comment 4 errata-xmlrpc 2021-07-27 14:28:41 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.8.0 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2920