Bug 1938468

Summary:	kube-scheduler-operator has a container without a CPU request
Product:	OpenShift Container Platform	Reporter:	Clayton Coleman <ccoleman>
Component:	kube-scheduler	Assignee:	Jan Chaloupka <jchaloup>
Status:	CLOSED ERRATA	QA Contact:	RamaKasturi <knarra>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.8	CC:	aos-bugs, mfojtik
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:53:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Clayton Coleman 2021-03-13 17:42:18 UTC

All payload components should request a reasonable minimum CPU and p90 memory usage

https://github.com/openshift/enhancements/blob/master/CONVENTIONS.md#resources-and-limits

The kube-scheduler-operator container does not specify a CPU.  Please follow recommendations in that doc.

Referenced from the new e2e test which gates components without resource requests and enforces the resource conventions.

Comment 1 Jan Chaloupka 2021-03-18 14:11:53 UTC

PR just waiting to be merged

Comment 3 RamaKasturi 2021-03-22 16:46:59 UTC

Verified bug with the payload below and i see that there is a cpu.

[knarra@knarra openshift-client-linux-4.8.0-0.nightly-2021-03-22-094046]$ ./oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.8.0-0.nightly-2021-03-22-094046   True        False         141m    Cluster version is 4.8.0-0.nightly-2021-03-22-094046

[knarra@knarra openshift-client-linux-4.8.0-0.nightly-2021-03-22-094046]$ ./oc get pod openshift-kube-scheduler-operator-f65db4b77-5qr9f -o yaml -n openshift-kube-scheduler-operator | grep -i cpu
                f:cpu: {}
        cpu: 10m
[knarra@knarra openshift-client-linux-4.8.0-0.nightly-2021-03-22-094046]$ ./oc get pod openshift-kube-scheduler-operator-f65db4b77-5qr9f -o yaml -n openshift-kube-scheduler-operator | grep -i memory
                f:memory: {}
        memory: 50Mi
    key: node.kubernetes.io/memory-pressure

In the previous version where the fix is not present i do not see cpu being listed:
===================================================================================
[knarra@knarra openshift-client-linux-4.8.0-0.nightly-2021-03-22-094046]$ ./oc get pod openshift-kube-scheduler-operator-84b8d76f7f-wqgt6 -o yaml -n openshift-kube-scheduler-operator | grep -i cpu
[knarra@knarra openshift-client-linux-4.8.0-0.nightly-2021-03-22-094046]$ ./oc get pod openshift-kube-scheduler-operator-84b8d76f7f-wqgt6 -o yaml -n openshift-kube-scheduler-operator | grep -i memory
                f:memory: {}
        memory: 50Mi
    key: node.kubernetes.io/memory-pressure

Based on the above moving bug to verified state.

Comment 6 errata-xmlrpc 2021-07-27 22:53:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438