Bug 1938491

Summary:	libspnav-devel is missing dependency on libX11-devel
Product:	[Fedora] Fedora	Reporter:	Scott K Logan <logans>
Component:	libspnav	Assignee:	John Morris <john>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	hobbes1069, john
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libspnav-0.2.3-13.el7 libspnav-0.2.3-13.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-02 00:44:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Scott K Logan 2021-03-13 22:25:45 UTC

Description of problem:
When libspnav is built, if X11 is enabled (which is the default behavior), the X11 dependency is encoded in a config header [1]. The 'spnav.h' header installed by libspnav-devel will then require the X11/xlib.h header provided by the libX11-devel package to be used at all. Therefore, the 'libspnav-devel' package should depend on libX11-devel.

Version-Release number of selected component (if applicable): 0.2.3-12.fc33

How reproducible: 100%

Steps to Reproduce:
1. On a minimal system, install libspnav-devel
2. Try to compile a program which has #include <spnav.h>

Actual results: fatal error: X11/Xlib.h: No such file or directory

Expected results: implicit dependencies of libspnav-devel are present on the system and compilation succeeds.

Additional info:
This bug appears to affect both Fedora and EPEL packages. I'm particularly interested in seeing this bug fixed in EPEL 8, but given how simple the fix is, it should probably be released on all supported platforms.

[1] https://github.com/FreeSpacenav/libspnav/blob/79ad169d8a690c2fbd532b07e62b5d797bcbbf62/configure#L106
[2] https://github.com/FreeSpacenav/libspnav/blob/79ad169d8a690c2fbd532b07e62b5d797bcbbf62/spnav.h#L30-L34

Thanks!

--scott

Comment 1 Richard Shaw 2021-03-15 12:16:33 UTC

Thanks, I've added it to the spec file. It will be included on the next build.

Comment 2 Scott K Logan 2021-03-15 17:32:59 UTC

> This bug appears to affect both Fedora and EPEL packages. I'm particularly interested in seeing this bug fixed in EPEL 8, but given how simple the fix is, it should probably be released on all supported platforms.

Please deploy the fix to the EPEL branches as well.

Thank you,

--scott

Comment 3 Richard Shaw 2021-03-16 12:10:00 UTC

Pushed to everything but f32.

Are you asking for builds? I think the number of people using the devel package would be quite small.

Comment 4 Scott K Logan 2021-03-16 19:09:50 UTC

I'm less concerned about the Fedora branches, but EPEL builds are few and far between. There hasn't been an EPEL 7 build since 2014. It would be great to get builds there if you could take the time.

Thanks,

--scott

Comment 5 Fedora Update System 2021-03-17 15:11:28 UTC

FEDORA-EPEL-2021-25ae6d2536 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-25ae6d2536

Comment 6 Fedora Update System 2021-03-17 15:11:29 UTC

FEDORA-EPEL-2021-ec2521048b has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ec2521048b

Comment 7 Fedora Update System 2021-03-18 03:45:16 UTC

FEDORA-EPEL-2021-25ae6d2536 has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-25ae6d2536

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-03-18 04:47:57 UTC

FEDORA-EPEL-2021-ec2521048b has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-ec2521048b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-04-02 00:44:37 UTC

FEDORA-EPEL-2021-25ae6d2536 has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 10 Fedora Update System 2021-04-02 01:55:44 UTC

FEDORA-EPEL-2021-ec2521048b has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.