Bug 1938982
| Summary: | Move libguestfs from PCRE to PCRE2 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Pisar <ppisar> |
| Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | rjones |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-03-16 14:30:52 UTC | Type: | Feature Request |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Petr Pisar
2021-03-15 12:03:52 UTC
Interesting - I didn't know anything about this. We use the C API, although nothing very complicated about it. However I cannot find any documentation on migration or the differences between the APIs. It seems as if most of the symbols have gone from pcre|PCRE -> pcre2|PCRE2. There is no migration guide. The basic approach remains the same, mostly only the prefix has changed. But there are slight differences, some data structures became opaque, some functions gained a new argument for a memory allocator to improve thread safety, API for an optional just-in-time matching was reworked, data types for Unicode code points and their UTF encoding were unified. I recommend you going through your code and checking the PCRE2 manual pages to see whether the functions differ. Again, there is pcre2demo(3) manual with an example application and pcre2api(3) with an index of the functions. That was a bunch of busy-work, but here you go: https://github.com/libguestfs/libguestfs/commit/82493579f38f39769861f31403ccfb8e97b41f96 Will be fixed in libguestfs 1.45.2. Thank you very much. |