Bug 1939168

Summary: Builds failing for OCP 3.11 since PR#25 was merged
Product: OpenShift Container Platform Reporter: Thiago Alessio Pereira <talessio>
Component: NodeAssignee: Ryan Phillips <rphillips>
Node sub component: Kubelet QA Contact: Sunil Choudhary <schoudha>
Status: CLOSED ERRATA Docs Contact:
Severity: urgent    
Priority: urgent CC: aos-bugs
Version: 3.11.0   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 22:53:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Thiago Alessio Pereira 2021-03-15 17:37:20 UTC 
Description of problem:


Latest build attempts are failing:
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1535660
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1535247
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1533974
https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=1532878

it looks like recent changes introduced by this PR https://github.com/openshift/node-problem-detector/pull/25/files broke 3.11 build.

+ export GOPATH=/builddir/build/BUILD/atomic-openshift-node-problem-detector-git-610.4222ca5/go
+ GOPATH=/builddir/build/BUILD/atomic-openshift-node-problem-detector-git-610.4222ca5/go
+ cd go/src/k8s.io/node-problem-detector
+ make bin/node-problem-detector VERSION=3.11.404-1.git.610.4222ca5.el7
CGO_ENABLED=1 GOOS=linux GO111MODULE=on go build \
	-mod vendor \
	-o bin/node-problem-detector \
	-ldflags '-X k8s.io/node-problem-detector/pkg/version.version=3.11.404-1.git.610.4222ca5.el7' \
	-tags " journald" \
	./cmd/nodeproblemdetector
flag provided but not defined: -mod
usage: build [-o output] [-i] [build flags] [packages]
Run 'go help build' for details.
make: *** [bin/node-problem-detector] Error 2
error: Bad exit status from /var/tmp/rpm-tmp.sExGfn (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.sExGfn (%build)
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target x86_64 --nodeps builddir/build/SPECS/node-problem-detector.spec']


Additional info:
There is no "release-3.11" branch in https://github.com/openshift/node-problem-detector, so "master" is being used to build the RPM for OCP 3.11.
Comment 2 Sunil Choudhary 2021-03-31 06:21:29 UTC 
I see the changes has been reverted in https://github.com/openshift/node-problem-detector/pull/28
Comment 5 errata-xmlrpc 2021-07-27 22:53:18 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438