Bug 1939326
| Summary: | ATOP is not collecting logs at mentioned interval | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | SASIKUMAR K <sasi1212> | ||||||
| Component: | atop | Assignee: | Gwyn Ciesla <gwync> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | epel7 | CC: | andy, gerlof.langeveld, gwync, sasi1212 | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | atop-2.6.0-5.fc34 atop-2.6.0-5.fc33 atop-2.6.0-5.fc32 atop-2.6.0-5.el7 atop-2.6.0-5.el8 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-03-28 00:15:39 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
SASIKUMAR K
2021-03-16 05:04:47 UTC
Does sudo systemctl daemon-reload, followed by sudo systemctl restart atop, help? It neither helps. Attached a sosreport just in case.
$ sudo systemctl status atop.service
● atop.service - Atop advanced performance monitor
Loaded: loaded (/usr/lib/systemd/system/atop.service; enabled; vendor preset: disabled)
Active: active (running) since Thu 2021-03-18 02:31:13 UTC; 45s ago
Docs: man:atop(1)
Process: 1433 ExecStartPost=/usr/bin/find ${LOGPATH} -name atop_* -mtime +${LOGGENERATIONS} -exec rm -v {} ; (code=exited, status=0/SUCCESS)
Process: 1430 ExecStartPre=/bin/sh -c test -n "$LOGGENERATIONS" -a "$LOGGENERATIONS" -eq "$LOGGENERATIONS" (code=exit
ed, status=0/SUCCESS)
Process: 1429 ExecStartPre=/bin/sh -c test -n "$LOGINTERVAL" -a "$LOGINTERVAL" -eq "$LOGINTERVAL" (code=exited, status=0/SUCCESS)
Main PID: 1432 (atop)
CGroup: /system.slice/atop.service
└─1432 /usr/bin/atop -w /var/log/atop/atop_20210318 60
Mar 18 02:31:13 ip-172-31-36-207.ap-south-1.compute.internal systemd[1]: Starting Atop advanced performance monitor...
Mar 18 02:31:13 ip-172-31-36-207.ap-south-1.compute.internal systemd[1]: Started Atop advanced performance monitor.
Hint: Some lines were ellipsized, use -l to show in full.
$ sudo systemctl daemon-reload
$ sudo systemctl restart atop
$ sudo systemctl status atop.service
● atop.service - Atop advanced performance monitor
Loaded: loaded (/usr/lib/systemd/system/atop.service; enabled; vendor preset: disabled)
Active: active (running) since Thu 2021-03-18 02:32:18 UTC; 3s ago
Docs: man:atop(1)
Process: 1482 ExecStartPost=/usr/bin/find ${LOGPATH} -name atop_* -mtime +${LOGGENERATIONS} -exec rm -v {} ; (code=exited, status=0/SUCCESS)
Process: 1479 ExecStartPre=/bin/sh -c test -n "$LOGGENERATIONS" -a "$LOGGENERATIONS" -eq "$LOGGENERATIONS" (code=exited, status=0/SUCCESS)
Process: 1478 ExecStartPre=/bin/sh -c test -n "$LOGINTERVAL" -a "$LOGINTERVAL" -eq "$LOGINTERVAL" (code=exited, status=0/SUCCESS)
Main PID: 1481 (atop)
CGroup: /system.slice/atop.service
└─1481 /usr/bin/atop -w /var/log/atop/atop_20210318 60
Mar 18 02:32:18 ip-172-31-36-207.ap-south-1.compute.internal systemd[1]: Stopped Atop advanced performance monitor.
Mar 18 02:32:18 ip-172-31-36-207.ap-south-1.compute.internal systemd[1]: Starting Atop advanced performance monitor...
Mar 18 02:32:18 ip-172-31-36-207.ap-south-1.compute.internal systemd[1]: Started Atop advanced performance monitor.
Hint: Some lines were ellipsized, use -l to show in full.
$ watch -n1 "date; ls -l /var/log/atop"
$ date; ls -l /var/log/atop
Thu Mar 18 02:34:11 UTC 2021
total 24
-rw-r--r--. 1 root root 20654 Mar 18 02:32 atop_20210318
$ sudo ps -ef | grep atop
root 1481 1 0 02:32 ? 00:00:00 /usr/bin/atop -w /var/log/atop/atop_20210318 60
ec2-user 1762 1303 0 02:34 pts/0 00:00:00 grep --color=auto atop
$ date; ls -l /var/log/atop
Thu Mar 18 02:36:04 UTC 2021
total 24
-rw-r--r--. 1 root root 20654 Mar 18 02:32 atop_20210318
Created attachment 1764261 [details]
SOSreport - Part A
$ md5sum sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz-PARTaa
bc489a5e84b0711cd48a07d0ddc06cc2 sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz-PARTaa
Created attachment 1764262 [details]
SOSreport - Part B
$ md5sum sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz-PARTab
506e8b34bac50cacd226554c9fe5317f sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz-PARTab
Merge steps:
$ cat sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz-PARTa* > sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz
$ md5sum sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz
$ md5sum sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz 0d85c3b52b8523a08d9879fba4b14de3 sosreport-ip-172-31-36-207-2021-03-18-bxzwuiy.tar.xz There seem to be some differences between the upstream atop rpm's /etc/default/atop and our /etc/sysconfig/atop. If you use there file in our location, do you see a change? Good guess. But it does not help. $ cat /etc/default/atop LOGOPTS="" LOGINTERVAL=60 LOGGENERATIONS=28 LOGPATH=/var/log/atop $ ls -lZ /etc/default/atop -rw-r--r--. root root system_u:object_r:etc_t:s0 /etc/default/atop $ sudo systemctl restart atop --- Some moments later --- $ date; ls -l /var/log/atop Mon Mar 22 18:26:18 UTC 2021 total 256 -rw-r--r--. 1 root root 213606 Mar 18 13:00 atop_20210318 -rw-r--r--. 1 root root 43804 Mar 22 18:24 atop_20210322 As you made me to compare ATOP RPM from EPEL and the one from upstream, I noted Python3 gets installed along with the upstream version, whereas it is not getting installed in EPEL version. I installed Python3 and restarted atop. But my guess is also not correct. Interesting. The python difference is because in EPEL we don't ship atopgpud because the python3-nvml module isn't available. Thanks for your update. Let me know in case if you need any further information from my lab. I've confirmed that 100% replacement of the file we ship as /etc/sysconfig/atop with the file upstream ships as /etc/sysconfig/atop fixes the issue. I'm pushing an update today. When you have it installed, replace your /etc/sysconfig/atop with /etc/sysconfig/atop.rpmnew, and customize. FEDORA-2021-f238ed0ea7 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f238ed0ea7 FEDORA-EPEL-2021-6b39871d3f has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-6b39871d3f FEDORA-2021-0f367a5b54 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-0f367a5b54 FEDORA-2021-956bbc2742 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-956bbc2742 FEDORA-EPEL-2021-631b5d8a32 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-631b5d8a32 FEDORA-2021-0f367a5b54 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0f367a5b54` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0f367a5b54 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-f238ed0ea7 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-f238ed0ea7` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f238ed0ea7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2021-6b39871d3f has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-6b39871d3f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2021-631b5d8a32 has been pushed to the Fedora EPEL 7 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-631b5d8a32 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-956bbc2742 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-956bbc2742` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-956bbc2742 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. I previously tested with the file "/etc/default/atop". However, after referring your recent correspondence I understood that we need to use the contents of upstream file "/etc/default/atop" and use it as "/etc/sysconfig/atop". And yes, it works, here are the results from my lab. $ cat /etc/sysconfig/atop.rpmsave # sysconfig atop # # Current Day format CURDAY=`date +%Y%m%d` # Log files path LOGPATH=/var/log/atop # Binaries path BINPATH=/usr/bin # PID File PIDFILE=/var/run/atop.pid # interval (default 10 minutes) LOGINTERVAL=60 $ cat /etc/sysconfig/atop LOGOPTS="" LOGINTERVAL=60 LOGGENERATIONS=28 LOGPATH=/var/log/atop [ec2-user@ip-172-31-36-207 ~]$ date; ls -l /var/log/atop Thu Mar 25 05:56:53 UTC 2021 total 484 -rw-r--r--. 1 root root 213606 Mar 18 13:00 atop_20210318 -rw-r--r--. 1 root root 157803 Mar 23 13:00 atop_20210322 -rw-r--r--. 1 root root 54767 Mar 25 05:56 atop_20210325 -rw-r--r--. 1 root root 22519 Mar 25 05:48 atop_20210325.save I have also tested the patched version 2.6.0-5 and it resolves the problem completely. https://kojipkgs.fedoraproject.org//packages/atop/2.6.0/5.el7/x86_64/atop-2.6.0-5.el7.x86_64.rpm Thanks a lot Gwyn Ciesla for fixing it. Really appreciate you. You're very welcome! I recently discovered that the real issue is in the atop.service file, where you can find:
Environment=LOGOPTS=""
The two double-quotes ("") cause an empty command line argument for atop, that reacts by taking an interval time of 0 seconds (which means: no time-driven intervals any more). This environment variable LOGOPTS is overruled by the /etc/default/atop file, so it also overrules the wrong specification in the atop.service file. LOGOPTS was not set in the original /etc/sysconfig/atop file, and therefor the wrong specification in the atop.service file was not overruled.
Please remove the two double-quotes in the atop.service file.
FEDORA-2021-0f367a5b54 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. What we now ship are the files provided in 2.6.0, with LOGOPTS="" in both the defaults/sysconfig file and the unit file, and that works in my testing. Will there be a release to address this in the near future? FEDORA-2021-f238ed0ea7 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-956bbc2742 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2021-631b5d8a32 has been pushed to the Fedora EPEL 7 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2021-6b39871d3f has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. |