Bug 1939412
| Summary: | missed labels for thanos-ruler pods | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Junqi Zhao <juzhao> |
| Component: | Monitoring | Assignee: | Pawel Krupa <pkrupa> |
| Status: | CLOSED ERRATA | QA Contact: | hongyan li <hongyli> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.8 | CC: | alegrand, anpicker, erooth, hongyli, jfajersk, kakkoyun, lcosic, pkrupa, spasquie |
| Target Milestone: | --- | Flags: | spasquie:
needinfo-
|
| Target Release: | 4.8.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-07-27 22:53:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Junqi Zhao
2021-03-16 11:22:21 UTC
For UWM stack components (which are private to users spinning up user workloads) would not need shared label prefixes like 'kubernetes.io' 'app.kubernetes.io'. @ (In reply to SriKrishna from comment #1) > For UWM stack components (which are private to users spinning up user > workloads) would not need shared label prefixes like 'kubernetes.io' > 'app.kubernetes.io'. > > @ Why other pods under openshift-user-workload-monitoring have those labels? assets deployed in the context of user workload monitoring (prometheus, thanos ruler, etc.) are not modifiable by the user, hence they should get the aforementioned labels. Test with payload 4.8.0-0.nightly-2021-05-06-162549 oc -n openshift-user-workload-monitoring get pod --show-labels NAME READY STATUS RESTARTS AGE LABELS prometheus-user-workload-0 5/5 Running 1 26s app.kubernetes.io/component=prometheus,app.kubernetes.io/instance=user-workload,app.kubernetes.io/managed-by=prometheus-operator,app.kubernetes.io/name=prometheus,app.kubernetes.io/part-of=openshift-monitoring,app.kubernetes.io/version=2.26.0,app=prometheus,controller-revision-hash=prometheus-user-workload-684dc4bc,operator.prometheus.io/name=user-workload,operator.prometheus.io/shard=0,prometheus=user-workload,statefulset.kubernetes.io/pod-name=prometheus-user-workload-0 prometheus-user-workload-1 5/5 Running 1 26s app.kubernetes.io/component=prometheus,app.kubernetes.io/instance=user-workload,app.kubernetes.io/managed-by=prometheus-operator,app.kubernetes.io/name=prometheus,app.kubernetes.io/part-of=openshift-monitoring,app.kubernetes.io/version=2.26.0,app=prometheus,controller-revision-hash=prometheus-user-workload-684dc4bc,operator.prometheus.io/name=user-workload,operator.prometheus.io/shard=0,prometheus=user-workload,statefulset.kubernetes.io/pod-name=prometheus-user-workload-1 thanos-ruler-user-workload-0 3/3 Running 0 21s app.kubernetes.io/instance=user-workload,app.kubernetes.io/managed-by=prometheus-operator,app.kubernetes.io/name=thanos-ruler,app=thanos-ruler,controller-revision-hash=thanos-ruler-user-workload-54969c8d7d,statefulset.kubernetes.io/pod-name=thanos-ruler-user-workload-0,thanos-ruler=user-workload thanos-ruler-user-workload-1 3/3 Running 0 21s app.kubernetes.io/instance=user-workload,app.kubernetes.io/managed-by=prometheus-operator,app.kubernetes.io/name=thanos-ruler,app=thanos-ruler,controller-revision-hash=thanos-ruler-user-workload-54969c8d7d,statefulset.kubernetes.io/pod-name=thanos-ruler-user-workload-1,thanos-ruler=user-workload thanos-ruler pods are still missing the following labels app.kubernetes.io/component app.kubernetes.io/part-of app.kubernetes.io/version Confirmed with Dev, can skip those 3. The most important ones were managed-by and name which have been added, change the bug as verified. https://coreos.slack.com/archives/G79AW9Q7R/p1620375313047900 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438 |