Bug 193965

Summary: "Grace" build failure because of wrong dependency on "xorg-x11-devel"
Product: [Fedora] Fedora Reporter: Joachim Frieben <jfrieben>
Component: graceAssignee: José Matos <jamatos>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: extras-qa
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-06-04 22:18:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Joachim Frieben 2006-06-03 14:01:33 UTC
Description of problem:
A rebuild of the "grace" package fails for the current development tree
because among the build requirements appears "xorg-x11-devel" which was
correct for FC4 but neither for FC5 not the current "rawhide" tree.

Version-Release number of selected component (if applicable):
grace-5.1.19-5.fc6

How reproducible:
Always.

Steps to Reproduce:
1. Execute "rpmbuild --rebuild grace-5.1.19-5.fc6.src.rpm"
  
Actual results:
Build aborts wit hthe message:
"error: Failed build dependencies:
        xorg-x11-devel is needed by grace-5.1.19-5.i386"

Expected results:
Package should compile cleanly.

Additional info:
None.

Comment 1 Joachim Frieben 2006-06-03 14:09:01 UTC
Ah, in the spec file, the following cases are distinguished:

%if "%{fedora}" >= "5"
BuildRequires: libXpm-devel
%else
BuildRequires: 11-devel
%endif

Seems that %{fedora} is not defined (correctly) for a current
rawhide system. This probably means that some other build
requirement is missing which makes sure that this variable is
set.

Comment 2 José Matos 2006-06-04 22:18:50 UTC
(In reply to comment #1)
> 
> Seems that %{fedora} is not defined (correctly) for a current
> rawhide system. This probably means that some other build
> requirement is missing which makes sure that this variable is
> set.

You need to define it, in the standard build system the fedora macro is 
defined to be the version of the release. I agree that i would be nice to have
this defined for development tools.

I close this as not a bug since the spec file is correct and it works in the 
building system. It follows established and documented procedures, so there is 
nothing wrong with the spec file.

Comment 3 Joachim Frieben 2006-06-05 07:16:06 UTC
I do not get your point. RPM packages have to build cleanly on a Fedora Core
system. This is the case for the "core" packages unless some "BuildReq" is
missing. Why would "extra" packages not be expected to rebuild correctly?
If additional components are required to rebuild the packages, they should
be added as build requirements in the spec file.

Comment 4 José Matos 2006-06-05 08:05:43 UTC
The guidelines that I refer are here: 
http://fedoraproject.org/wiki/DistTag

Search there for conditionals.

If you disagree I suggest you to bring this issue to fedora-extras-list
for discussion. I am saying this in all fairness :-) I don't think this is
the right place to discuss this.

If I remember correctly there were some previous threads about this subject
but I do not remember the outcome. :-)