Bug 193982

Summary: Review Request: osgal - Adapts OpenSceneGraph to use OpenAL++
Product: [Fedora] Fedora Reporter: Christopher Stone <chris.stone>
Component: Package ReviewAssignee: Hans de Goede <hdegoede>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Package Reviews List <fedora-package-review>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhide   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-06-14 07:03:56 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 193934    
Bug Blocks: 163779    

Description Christopher Stone 2006-06-03 21:34:50 UTC
Spec URL: http://tkmame.retrogames.com/fedora-extras/osgal.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/osgal-20060410-2.src.rpm

Description:
osgAL is a toolkit for handling spatial (3D) sound in the OpenSceneGraph
rendering library.

Comment 1 Hans de Goede 2006-06-07 13:54:29 UTC
Hi,

Starting a review for this. I hope to be back soon with the actual review.


Comment 2 Hans de Goede 2006-06-07 14:20:03 UTC
MUST:
=====
* rpmlint output is clean 
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License (LGPL) ok, license file included
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel-i386
* BR: ok
* No locales
* ldconfig properly called for shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files & Permissions ok
* %clean & macro usage OK
* Contains code only
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* proper -devel package as needed
* .la files not packaged
* no gui -> no .desktop file required

Questions/Remarks:
==================
* Whats this? : "/usr/lib/libosgdb_osgAL.so"
* What does the -version-info 1:0:0 in osgal-cvs-debian-01.dpatch do?


Approved!