Bug 1939853

Summary: [DOC] Creating manifests API should not allow folder in the "file_name"
Product: OpenShift Container Platform Reporter: Constantin Vultur <cvultur>
Component: assisted-installerAssignee: Moti Asayag <masayag>
assisted-installer sub component: assisted-service QA Contact: Yuri Obshansky <yobshans>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: alazar, aos-bugs, lgamliel, sasha
Version: 4.8   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: OCP-Metal-V1.0.18.1 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 22:53:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Constantin Vultur 2021-03-17 08:47:45 UTC 
Description of problem:
Update on documentation is needed on : https://github.com/openshift/assisted-service/blob/master/docs/user-guide/install-customization.md#manifests

Problem is described on : https://bugzilla.redhat.com/show_bug.cgi?id=1939845

Version-Release number of selected component (if applicable):
Assisted Installer
quay.io/ocpmetal/assisted-installer:0645568814701c122bed3ad9a25c9bcdf30215ef
Assisted Installer Controller
quay.io/ocpmetal/assisted-installer-controller:0645568814701c122bed3ad9a25c9bcdf30215ef
Assisted Installer Service
quay.io/ocpmetal/assisted-service:62f6a12f9790dff75397c65cfd652215ab83a088
Discovery Agent
quay.io/ocpmetal/assisted-installer-agent:edbaff3f6b1343b6e51c64d461923ac592820476


How reproducible:


Steps to Reproduce:
1. Use the https://github.com/openshift/assisted-service/blob/master/docs/user-guide/install-customization.md#manifests to create a manifest
2.
3.

Actual results:
User adds folder name to the "file_name" param

Expected results:
Documentation should be updated to include the folder as a separate parameter to the API call:

file=99-openshift-machineconfig-master-kargs.yaml
folder=openshift

curl \
    --header "Content-Type: application/json" \
    --header "Authorization: Bearer $TOKEN" \
    --request POST \
    --data "{\"file_name\":\"$file\", \"folder\": \"$folder\", \"content\":\"$content\"}" \


Additional info:
Comment 1 Nick Carboni 2021-03-18 12:44:58 UTC 
This is a docs issue so it should be resolved by https://github.com/openshift/assisted-service/pull/1344
Comment 2 Constantin Vultur 2021-03-25 08:35:32 UTC 
Latest doc on https://github.com/openshift/assisted-service/blob/master/docs/user-guide/install-customization.md#manifests is updated. 

Marking as Verified
Comment 5 errata-xmlrpc 2021-07-27 22:53:48 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438