Bug 1940094

Summary: AWS agents: dont spam logs when getting token
Product: Red Hat Enterprise Linux 8 Reporter: Oyvind Albrigtsen <oalbrigt>
Component: resource-agentsAssignee: Oyvind Albrigtsen <oalbrigt>
Status: CLOSED ERRATA QA Contact: Brandon Perkins <bperkins>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.4CC: agk, bperkins, cluster-maint, fdinitto, phagara
Target Milestone: rcKeywords: Triaged
Target Release: 8.5   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: resource-agents-4.1.1-91.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1940098 (view as bug list) Environment:
Last Closed: 2021-11-09 17:27:32 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1940098    

Description Oyvind Albrigtsen 2021-03-17 15:41:06 UTC
Description of problem:
After we introduced IMDSv2 support the AWS agents spam logfiles during monitor action when getting the token due to curl outputting progress to stderr when not run in terminal.

Example:
Mar 17 10:59:03 rhel8-1 pacemaker-execd     [14377] (log_op_output)     notice: vpcip_monitor_0[14417] error output [   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current ]
Mar 17 10:59:03 rhel8-1 pacemaker-execd     [14377] (log_op_output)     notice: vpcip_monitor_0[14417] error output [                                  Dload  Upload   Total   Spent    Left  Speed ]
Mar 17 10:59:03 rhel8-1 pacemaker-execd     [14377] (log_op_output)     notice: vpcip_monitor_0[14417] error output [ ^M  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0^M100    56  100    56    0     0   3500      0 --:--:-- --:--:-- --:--:--  3733 ]

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Setup a resource with any of the AWS agents, and look in /var/log/pacemaker/pacemaker.log for the error output above.
2.
3.

Actual results:
Spams logfile

Expected results:
Doesnt spam logfile

Additional info:
https://github.com/ClusterLabs/resource-agents/pull/1626/commits/59b0840d262900d0eaa8b19df3ede55eea5250d2

Comment 3 Dean Jansa 2021-04-08 17:06:07 UTC
ON_QA bug without Verified:Tested should be in the MODIFIED state.

Comment 5 Dean Jansa 2021-04-15 08:00:51 UTC
ON_QA bug without Verified:Tested should be in the MODIFIED state.

Comment 9 errata-xmlrpc 2021-11-09 17:27:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: resource-agents security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4139