Bug 1940707

Summary:	Windows SSO is broken, Error writing credentials to pipe
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Germano Veit Michel <gveitmic>
Component:	ovirt-guest-agent	Assignee:	Gal Zaidman <gzaidman>
Status:	CLOSED WONTFIX	QA Contact:	Nisim Simsolo <nsimsolo>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4.4	CC:	gzaidman, lsurette, lveyde, mhicks, michal.skrivanek, mkenneth, nsimsolo, sbonazzo, srevivo, tgolembi
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-28 09:52:15 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Germano Veit Michel 2021-03-18 23:59:28 UTC

Description of problem:

This is the same as upstream BZ1449181. That BZ was closed because ovirt-guest-agent would be replaced by qemu-guest-agent, but QGA does not provide SSO, this is still handled by OGA. Also see BZ1933885 comment#10 for supportability state of ovirt-guest-agent on Windows regarding SSO on RHV 4.4.

VDSM sends the command to OGA fine:
2021-03-18 23:48:18,861+0000 INFO  (jsonrpc/6) [api.virt] START desktopLogin(domain='internal-authz', username='germano', password='********') from=::ffff:192.168.100.253,51308, flow_id=09f173a6-1e2d-477b-8ef4-fb03a5bc143c, vmId=aacff63a-2016-4514-a310-0774529c8316 (api:48)
2021-03-18 23:48:18,861+0000 INFO  (jsonrpc/6) [api.virt] FINISH desktopLogin return={'status': {'code': 0, 'message': 'Done'}} from=::ffff:192.168.100.253,51308, flow_id=09f173a6-1e2d-477b-8ef4-fb03a5bc143c, vmId=aacff63a-2016-4514-a310-0774529c8316 (api:54)

But OGA fails:
Dummy-2::INFO::2021-03-18 23:48:18,377::ovirtagentlogic::322::root::Received an external command: login...
Dummy-2::ERROR::2021-03-18 23:48:19,420::guestagentwin32::326::root::Error writing credentials to pipe [1/3] (error = 2)
Dummy-2::ERROR::2021-03-18 23:48:20,436::guestagentwin32::326::root::Error writing credentials to pipe [2/3] (error = 2)
Dummy-2::ERROR::2021-03-18 23:48:21,450::guestagentwin32::326::root::Error writing credentials to pipe [3/3] (error = 2)

I can't find the oVirtCredentialsProvider DLL installed (which AFAIK provides the VDSMD named pipe)

Version-Release number of selected component (if applicable):
* Windows 10 Pro (20H2, Build 19042.631 - latest as of today)
* ovirt-engine-4.4.4.7-0.2.el8ev.noarch
* vdsm-4.40.40-1.el8ev.x86_64
* virtio-win-1.9.15.iso

How reproducible:
100%

Steps to Reproduce:
1. Install Windows 10 Guest
2. Install latest ovirt-guest-agent from virtio-win
3. Configure and attempt SSO

Actual results:
* User not logged in

Expected results:
* User logged in

Comment 1 Germano Veit Michel 2021-03-19 00:25:56 UTC

There is a FILE_RHEVCredProv.dll_amd64.inf inside the ovirt-guest-agent installer, but right click and install fails.
Also tried to regsrv32 and it as a DLL and it failed too.

Comment 2 Germano Veit Michel 2021-03-19 00:29:45 UTC

Any ideas how to get that RHEVCredProv.dll manually installed as a workaround?

Comment 3 Michal Skrivanek 2021-03-19 11:09:39 UTC

Lev, any idea?

Comment 9 Lev Veyde 2021-03-25 00:11:53 UTC

After a successful debugging session with Germano it looks like a case of missing credential provider and it's registration.

Comment 13 Gal Zaidman 2021-06-28 09:52:15 UTC

The ovirt ga windows is deprecated and removed on el8[1], opened[2] to remove it from the virtio-win installer.
Closing it as WONTFIX since we are removing SSO

[1] https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html/release_notes/deprecated_features_rhv
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1976799