Bug 1940896

Summary:	Provider inventory changes not reflected in related custom resources
Product:	Migration Toolkit for Virtualization	Reporter:	Jeff Ortel <jortel>
Component:	General	Assignee:	Jeff Ortel <jortel>
Status:	CLOSED ERRATA	QA Contact:	Amos Mastbaum <amastbau>
Severity:	high	Docs Contact:	Avital Pinnick <apinnick>
Priority:	high
Version:	2.0.0	CC:	fdupont, istein
Target Milestone:	---
Target Release:	2.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-06-10 17:11:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeff Ortel 2021-03-19 14:00:53 UTC

Description of problem:

Inventory changes are not reflected in CR status. For example: A plan with a critical condition for a VM already exists on the destination cluster will not be cleared when the problem is resolved by deleting the VM.  This issue affects the following CRs:
- Plan
- NetworkMap
- StorageMap
- Host

Version-Release number of selected component (if applicable):

ALL.

How reproducible:

Always.


Steps to Reproduce:
1. Create a Plan with a VM that already exists on the destination.
2. Note the CRITICAL condition.
3. Delete the VM on the destination.
4. Not the condition is not cleared.

Actual results:

Reconcile is not triggered and the condition is not cleared.


Expected results:

The change in the inventory should result in the CR being reconciled and the condition cleared.  I don't think this need to be in real-time but perhaps within a minute is a reasonable expectation.


Additional info:

Comment 1 Jeff Ortel 2021-03-31 18:10:07 UTC

https://github.com/konveyor/forklift-controller/pull/194
https://github.com/konveyor/forklift-controller/pull/204

Comment 2 Fabien Dupont 2021-04-08 11:52:29 UTC

This fix should be part of build v2.0.0-14, iib:64369.

Comment 4 Amos Mastbaum 2021-05-09 11:37:03 UTC

Verified Plan

Next: Verify the other CRS

Comment 5 Amos Mastbaum 2021-05-09 12:24:17 UTC

Verified:

Plan -  as describe in the reproduction steps.

Network - Create a NAD after networkmap is created and goes to NAD NotFound condition reason

Storage - Create Storage Class after storagemap is created and  goes to StorageClass NotFound condition reason

Host - wip

Comment 6 Amos Mastbaum 2021-05-10 09:39:19 UTC

@jortel 
@

I run the following scenario:

1. Created a host (UI) and allow it to become ready.
2. Put the host in maintenance mode.

The Host remains in the same condition (and the migration fails, for obvious reason).


 

cc: fdupont 
cc: istein

Comment 7 Jeff Ortel 2021-05-10 14:47:42 UTC

When watching inventory resources, each controller has a deliberately narrow set of changes it's interested in.  For Host, it only triggers a Host CR reconcile when a referenced (vCenter) Host's path and/or name changes.  We'd need to expand to include changes to: maintenance mode.
However, we currently don't validate maintenance-mode in the back-end so the even if the Plan reconcile is triggered by the change in maintenance-mode, the Host CR will remain READY and the Plan will execute.

Comment 8 Amos Mastbaum 2021-05-11 09:33:09 UTC

Host CR also verified.
Closing this BZ, continue is : https://bugzilla.redhat.com/show_bug.cgi?id=1959306

Comment 11 errata-xmlrpc 2021-06-10 17:11:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (MTV 2.0.0 images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2381

Comment 12 Red Hat Bugzilla 2023-09-15 01:03:43 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days