Bug 1942242

Summary:	Review Request: python-s-tui - Terminal-based CPU stress and monitoring utility
Product:	[Fedora] Fedora	Reporter:	Artem <ego.cordatus>
Component:	Package Review	Assignee:	Vasiliy Glazov <vascom2>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, vascom2
Target Milestone:	---	Flags:	vascom2: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-26 20:45:00 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Artem 2021-03-23 23:19:45 UTC

Spec URL: https://atim.fedorapeople.org/python-s-tui.spec
SRPM URL: https://atim.fedorapeople.org/python-s-tui-1.1.1-1.fc33.src.rpm

Description:
Stress-Terminal UI, s-tui, monitors CPU temperature, frequency, power and
utilization in a graphical way from the terminal.

What it does

  * Monitoring your CPU temperature/utilization/frequency/power
  * Shows performance dips caused by thermal throttling
  * Requires no X-server
  * Built in options for stressing the CPU (stress/stress-ng/FIRESTARTER)

Fedora Account System Username: atim

Comment 1 Artem 2021-03-23 23:19:48 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=64463745

Comment 2 Vasiliy Glazov 2021-03-24 04:46:31 UTC

First of all it seems need change license to GPLv2+

Comment 3 Vasiliy Glazov 2021-03-24 04:54:37 UTC

Make scripts executable or remove shebang:

python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/about_menu.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/help_menu.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/helper_functions.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/s_tui.py 644 /usr/bin/python 
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sensors_menu.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/fan_source.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/freq_source.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/hook.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/hook_script.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/rapl_power_source.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/rapl_read.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/script_hook_loader.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/source.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/temp_source.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sources/util_source.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/stress_menu.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sturwid/bar_graph_vector.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sturwid/complex_bar_graph.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sturwid/summary_text_list.py 644 /usr/bin/env python
python3-s-tui.noarch: E: non-executable-script /usr/lib/python3.9/site-packages/s_tui/sturwid/ui_elements.py 644 /usr/bin/env python

Comment 4 Artem 2021-03-24 10:59:01 UTC

Thanks for review. New build:

https://atim.fedorapeople.org/for-review/python-s-tui.spec
https://atim.fedorapeople.org/for-review/python-s-tui-1.1.1-2.fc33.src.rpm

Comment 5 Artem 2021-03-26 09:05:35 UTC

https://atim.fedorapeople.org/for-review/python-s-tui.spec
https://atim.fedorapeople.org/for-review/python-s-tui-1.1.1-3.fc33.src.rpm

Comment 6 Vasiliy Glazov 2021-03-26 10:22:09 UTC

Approved.

Full review report will be added soon.

Comment 7 Gwyn Ciesla 2021-03-26 13:20:16 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-s-tui

Comment 8 Fedora Update System 2021-03-26 14:32:10 UTC

FEDORA-2021-e149b6226c has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e149b6226c

Comment 9 Fedora Update System 2021-03-26 14:38:38 UTC

FEDORA-2021-a3f0e24280 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a3f0e24280

Comment 10 Artem 2021-03-26 20:45:00 UTC

Closing in favor RH#1943701. Closing old one due wrong python app naming.

*** This bug has been marked as a duplicate of bug 1943701 ***