Bug 1943488

Summary:	Changing ovn-cms-options is not reflected on the node
Product:	Red Hat OpenStack	Reporter:	PURANDHAR SAIRAM MANNIDI <pmannidi>
Component:	openstack-tripleo-heat-templates	Assignee:	PURANDHAR SAIRAM MANNIDI <pmannidi>
Status:	CLOSED ERRATA	QA Contact:	Eduardo Olivares <eolivare>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	16.1 (Train)	CC:	akatz, ekuris, jamsmith, jappleii, jlibosva, mburns, ramishra
Target Milestone:	z7	Keywords:	Triaged
Target Release:	16.1 (Train on RHEL 8.2)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-11.3.2-1.20210428163859.29a02c1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-12-09 20:18:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description PURANDHAR SAIRAM MANNIDI 2021-03-26 08:12:31 UTC

Description of problem:
Disabling DVR in existing OVN+DVR deployment doesn't remove ovn-cms-options from ovs. We have to manually remove the ovn-cms-options.

Version-Release number of selected component (if applicable):
Red Hat OpenStack Platform 16.1 or later

How reproducible:
Always

Steps to Reproduce:
1. Deploy an overcloud with OVN+DVR+HA
2. Disable DVR by setting EnableNeutronDVR to False
3. Remove OVNCMSOptions from ComputeParameters
4. Rerun the deploy command.

Actual results:
Compute OVS has ovn-cms-options in OVS 

Expected results:
Compute OVS should not have ovn-cms-options set in Open_vSwitch table of OVS.

Additional info:

Comment 1 PURANDHAR SAIRAM MANNIDI 2021-03-26 08:19:21 UTC

Issue is at https://github.com/openstack/tripleo-heat-templates/blob/master/deployment/ovn/ovn-controller-container-puppet.yaml#L242

            command: ['/bin/bash', '-c', 'CMS_OPTS=$(hiera ovn::controller::ovn_cms_options -c /etc/puppet/hiera.yaml);  if [ X"$CMS_OPTS" !=  X ]; then ovs-vsctl set open . external_ids:ovn-cms-options=$CMS_OPTS; fi']

It should have been:

           command: ['/bin/bash', '-c', 'CMS_OPTS=$(hiera ovn::controller::ovn_cms_options -c /etc/puppet/hiera.yaml);  if [ X"$CMS_OPTS" !=  X ]; then ovs-vsctl set open . external_ids:ovn-cms-options=$CMS_OPTS;else ovs-vsctl remove open . external_ids ovn-cms-options; fi']

Comment 28 errata-xmlrpc 2021-12-09 20:18:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.7 (Train) bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:3762