Bug 1944087

Summary: [RFE] print warning when multiple "--device=" options are used to create vdo device
Product: Red Hat Enterprise Linux 8 Reporter: Rupesh Girase <rgirase>
Component: vdoAssignee: bjohnsto
Status: CLOSED ERRATA QA Contact: Filip Suba <fsuba>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 8.3CC: awalsh, cwei, fsuba
Target Milestone: rcKeywords: FutureFeature, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: vdo- Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 19:28:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Rupesh Girase 2021-03-29 09:14:53 UTC
Description of problem:
print warning when multiple "--device=" options are used to create vdo device as it uses one block device only 

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:

o Create vdo with multiple --device options
used these two block devices
nvme0n6                        259:7    0  74.5G  0 disk 
nvme0n7                        259:8    0  74.5G  0 disk 

# vdo create --name=multivdo --device=/dev/nvme0n6 --device=/dev/nvme0n7 --vdoSlabSize=256M 
Creating VDO multivdo
      Logical blocks defaulted to 18716406 blocks.
      The VDO volume can address 71 GB in 287 data slabs, each 256 MB.
      It can grow to address at most 2 TB of physical storage in 8192 slabs.
      If a larger maximum size might be needed, use bigger slabs.
Starting VDO multivdo
Starting compression on VDO multivdo
VDO instance 3 volume is ready at /dev/mapper/multivdo

Actual results:
Creates vdo volume with one block device only and does not tell anything about other one

Expected results:
warning should be printed saying other device is ignored or not used

Additional info:

Comment 5 Filip Suba 2021-05-27 13:19:17 UTC
Verified with vdo-
# vdo create -n vdo --device /dev/sdc --device /dev/sdd
usage: vdo create [-h] -n <volume> --device <devicepath>
                  [--activate {disabled,enabled}]
                  [--blockMapCacheSize <megabytes>]
                  [--blockMapPeriod <period>]
                  [--compression {disabled,enabled}]
                  [--deduplication {disabled,enabled}]
                  [--emulate512 {disabled,enabled}] [--force]
                  [--indexMem <gigabytes>] [--maxDiscardSize <megabytes>]
                  [--sparseIndex {disabled,enabled}] [--uuid <uuid>]
                  [--vdoAckThreads <threadCount>]
                  [--vdoBioRotationInterval <ioCount>]
                  [--vdoBioThreads <threadCount>]
                  [--vdoCpuThreads <threadCount>]
                  [--vdoHashZoneThreads <threadCount>]
                  [--vdoLogicalSize <megabytes>]
                  [--vdoLogicalThreads <threadCount>]
                  [--vdoLogLevel {critical,error,warning,notice,info,debug}]
                  [--vdoPhysicalThreads <threadCount>]
                  [--vdoSlabSize <megabytes>]
                  [--writePolicy {async,async-unsafe,sync,auto}] [-f <file>]
                  [--logfile <pathname>] [--verbose]
vdo create: error: option 'device' was specified more than once

Comment 8 errata-xmlrpc 2021-11-09 19:28:28 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (kmod-kvdo bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.