Bug 1944463

Summary:	Review Request: rust-pam-client - Application API wrapper to Pluggable Authentication Modules (PAM)
Product:	[Fedora] Fedora	Reporter:	Rémi Lauzier <remilauzier>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review, remilauzier
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-11 05:06:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1901106
Bug Blocks:	1941896

Description Rémi Lauzier 2021-03-30 01:04:10 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-34-x86_64/02108012-rust-pam-client/rust-pam-client.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-34-x86_64/02108012-rust-pam-client/rust-pam-client-0.2.0-1.fc34.src.rpm
Description: Application API wrapper to Pluggable Authentication Modules (PAM)
Fedora Account System Username: remilauzier

Comment 1 Robert-André Mauchin 🐧 2021-04-03 16:43:57 UTC

 - Could you make sure that in all you Rust request you've included the license file in the devel subpackage:

%package        devel
Summary:        %{summary}
BuildArch:      noarch

%description    devel %{_description}

This package contains library source intended for building other packages
which use "%{crate}" crate.

%files          devel
%doc README.md
%license LICENSE
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - Similarly, please add a comment explaining what changes did you make to the Casgo.toml(s)

Comment 2 Rémi Lauzier 2021-04-03 17:28:56 UTC

Hi!
Just want to know, do i have to include the license if the git repo contain none?
Do i have to point to a file somewhere?
There's two package in this situation.

Comment 3 Rémi Lauzier 2021-04-03 17:51:56 UTC

Hi!
I manager to compile rust-pam-client without the patch.
https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-34-x86_64/02113835-rust-pam-client/rust-pam-client.spec
https://download.copr.fedorainfracloud.org/results/remilauzier/rudo/fedora-34-x86_64/02113835-rust-pam-client/rust-pam-client-0.2.0-1.fc34.src.rpm

Comment 4 Robert-André Mauchin 🐧 2021-04-03 18:31:00 UTC

(In reply to Rémi Lauzier from comment #2)
> Hi!
> Just want to know, do i have to include the license if the git repo contain
> none?
> Do i have to point to a file somewhere?
> There's two package in this situation.

No, but you should file a bug report asking upstream to add it to their crate, then add a link to the bug above the License; field.

Comment 5 Rémi Lauzier 2021-04-03 21:04:31 UTC

Hi!
I have done all the bug report and put the link in the .spec file.
i have import in the source from github for those where the file exist and put the link to the bug report.

Comment 6 Robert-André Mauchin 🐧 2021-04-06 20:17:27 UTC

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved. You still need to find a sponsor.

Comment 7 Robert-André Mauchin 🐧 2021-04-08 21:28:19 UTC

Sponsored.

Comment 8 Tomas Hrcka 2021-04-27 09:26:33 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pam-client