Bug 1944554
Summary: | Review Request: perl-Glib-IO - Perl binding to the GIO library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Michal Josef Spacek <mspacek> |
Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | rawhide | CC: | jplesnik, package-review, ppisar |
Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | perl-Glib-IO-0.001-1.fc35 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-05-05 17:49:48 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Michal Josef Spacek
2021-03-30 07:49:51 UTC
BTW: This package is my first package in Fedora :-) Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-Glib-IO-0.001-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(Glib::Object::Introspection) >= 0.014 1 perl(:MODULE_COMPAT_5.32.1) 1 perl(strict) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-Glib-IO-0.001-1.fc35.noarch.rpm | sort | uniq -c 1 perl(Glib::IO) = 0.001 1 perl-Glib-IO = 0.001-1.fc35 Binary provides are Ok. $ rpmlint ./perl-Glib-IO* 2 packages and 1 specfiles checked; 0 errors, 0 warnings. Rpmlint is ok The package is in line with Fedora and Perl packaging guide lines. Resolution: I am not a sponsor of packagers. However for me, the package can be approved. I cannot see where Glib module is used in the tests (grep -Hnr 'Glib[^:]' ./t). Do we really need perl(Glib) among BuildRequires? (In reply to Petr Pisar from comment #3) > I cannot see where Glib module is used in the tests (grep -Hnr 'Glib[^:]' > ./t). Do we really need perl(Glib) among BuildRequires? There is usage of Glib::MainLoop in t/file-enumerator.t The usage is this one: my $loop = Glib::MainLoop->new (); That does not load Glib module. The test just expects that Glib::MainLoop was imported implicitly somewhere somehow (probably by Glib transitively loaded by "use Glib::IO;" at line #5). It's maybe a deficiency in the test, but the RPM dependency should not be there: [test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'Glib::MainLoop->new' Can't locate object method "new" via package "Glib::MainLoop" (perhaps you forgot to load "Glib::MainLoop"?) at -e line 1. [test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'use Glib::MainLoop; Glib::MainLoop->new' Can't locate Glib/MainLoop.pm in @INC (you may need to install the Glib::MainLoop module) (@INC contains: lib /usr/local/lib64/perl5/5.32 /usr/local/share/perl5/5.32 /usr/lib64/perl5/vendor_perl /usr/share/perl5/vendor_perl /usr/lib64/perl5 /usr/share/perl5) at -e line 1. BEGIN failed--compilation aborted at -e line 1. [test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'use Glib; Glib::MainLoop->new' [test@fedora-35 Glib-IO-0.001]$ perl -Ilib -e 'use Glib::IO; Glib::MainLoop->new' [test@fedora-35 Glib-IO-0.001]$ (In reply to Petr Pisar from comment #5) > The usage is this one: > > my $loop = Glib::MainLoop->new (); > > That does not load Glib module. The test just expects that Glib::MainLoop > was imported > implicitly somewhere somehow (probably by Glib transitively loaded by "use > Glib::IO;" > at line #5). It's maybe a deficiency in the test, but the RPM dependency > should not be there: Yes, you are right. I removed this dependency. https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm Thanks. (In reply to Michal Josef Spacek from comment #6) > (In reply to Petr Pisar from comment #5) > > The usage is this one: > > > > my $loop = Glib::MainLoop->new (); > > > > That does not load Glib module. The test just expects that Glib::MainLoop > > was imported > > implicitly somewhere somehow (probably by Glib transitively loaded by "use > > Glib::IO;" > > at line #5). It's maybe a deficiency in the test, but the RPM dependency > > should not be there: > > Yes, you are right. > I removed this dependency. > > https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO.spec > https://skim.cz/tmp/perl-Glib-IO-2/perl-Glib-IO-0.001-1.fc35.src.rpm > > Thanks. # Tests: -BuildRequires: perl(Glib) BuildRequires: perl(Test::More) Package looks good now. Resolution: Approved (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Glib-IO Thank you for review and repository. |