Bug 1944641
Summary: | Not selecting Apply later option after editing running VM still triggers VM next run configuration | ||
---|---|---|---|
Product: | [oVirt] ovirt-engine | Reporter: | Ivana Saranova <isaranov> |
Component: | BLL.Virt | Assignee: | Liran Rotenberg <lrotenbe> |
Status: | CLOSED DUPLICATE | QA Contact: | Guilherme Santos <gdeolive> |
Severity: | medium | Docs Contact: | |
Priority: | unspecified | ||
Version: | 4.4.5.11 | CC: | ahadas, bugs, michal.skrivanek |
Target Milestone: | --- | Keywords: | Automation |
Target Release: | --- | Flags: | pm-rhel:
ovirt-4.4+
|
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2021-04-22 12:55:26 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | Virt | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Ivana Saranova
2021-03-30 11:49:47 UTC
logs never hurt even if it is easy to reproduce. Please attach Probably due to changes of the max memory which requires restart but need to check (In reply to Arik from comment #2) > Probably due to changes of the max memory which requires restart but need to check No, that's unrelated to the max memory configuration (although the UI tries to update the max-memory also when the VM is powering up which seems like a bug). We have the following comment in the code that sets the next-run configuration in this case: "Annotation EditableVmField defines VmBase#memSizeMb as hot settable however the snapshot is needed * while increasing memory since hotplug is only allowed for certain values (multiples of 256MiB by default) * while decreasing memory since hot unplug is only allowed from REST (not allowed from Edit VM dialog) * when VM is not in state {@link VMStatus#Up} or {@link VMStatus#Down} since memory hot (un)plugs can only be done in state Up" This bug is related to the first case of hot-plug - we create the next run snapshot also in case the difference is a multiply of 256MiB let's start with checking what's the memory-size in vm_static after the hot-plug The properties on the DB updates on the update command. On shutdown the new DIMM device is unmanaged and will be dropped on the next run command. There is no need of the next-run configuration. We should check if the added value is divided by 256 and if it does don't invoke the next run snapshot creation. *** This bug has been marked as a duplicate of bug 1779983 *** |