Bug 1945579

Summary: [FTBFS] oidn: error: call to non-'constexpr' function 'long int sysconf(int)'
Product: [Fedora] Fedora Reporter: Jonathan Wakely <jwakely>
Component: oidnAssignee: Luya Tshimbalanga <luya_tfz>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: luya_tfz, negativo17
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: oidn-1.4.0-1.fc35 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-28 02:02:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jonathan Wakely 2021-04-01 10:35:16 UTC
Description of problem:

oidn fails to build in rawhide


Version-Release number of selected component (if applicable):

oidn-1.3.0-2.fc35

How reproducible:

always

Steps to Reproduce:
1. fedpkg build

Actual results:
https://koji.fedoraproject.org/koji/taskinfo?taskID=64923968

Expected results:
builds

Additional info:

This is due to the glibc change to MINSIGSTKSZ such that it's no longer a compile-time constant.

In file included from /usr/include/signal.h:315,
                 from /builddir/build/BUILD/oidn-1.3.0/apps/catch.hpp:8034,
                 from /builddir/build/BUILD/oidn-1.3.0/apps/oidnTest.cpp:12:
/builddir/build/BUILD/oidn-1.3.0/apps/catch.hpp:10822:58: error: call to non-'constexpr' function 'long int sysconf(int)'
10822 |     static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;
      |                                                          ^~~~~~~~~~~
In file included from /usr/include/bits/sigstksz.h:24,
                 from /usr/include/signal.h:315,
                 from /builddir/build/BUILD/oidn-1.3.0/apps/catch.hpp:8034,
                 from /builddir/build/BUILD/oidn-1.3.0/apps/oidnTest.cpp:12:
/usr/include/unistd.h:630:17: note: 'long int sysconf(int)' declared here
  630 | extern long int sysconf (int __name) __THROW;
      |                 ^~~~~~~
In file included from /builddir/build/BUILD/oidn-1.3.0/apps/oidnTest.cpp:12:
/builddir/build/BUILD/oidn-1.3.0/apps/catch.hpp:10881:45: error: size of array 'altStackMem' is not an integral constant-expression
10881 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};
      |                                             ^~~~~~~~~~~~

Comment 1 Luya Tshimbalanga 2021-04-28 02:02:07 UTC
Upstream addressed this bug and fixed on their development branch as highlighted on their Github ticket. Closing this report.

Comment 2 Jonathan Wakely 2021-05-11 09:17:26 UTC
It's still broken in rawhide though:
https://bugzilla.redhat.com/show_bug.cgi?id=1959312

Comment 3 Luya Tshimbalanga 2021-05-11 23:22:45 UTC
New build available with patch taken from upstream devel branch.
https://koji.fedoraproject.org/koji/taskinfo?taskID=67725731

Comment 4 Fedora Update System 2021-05-19 06:46:58 UTC
FEDORA-2021-258785fae6 has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-258785fae6

Comment 5 Fedora Update System 2021-05-19 06:47:26 UTC
FEDORA-2021-258785fae6 has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.