Bug 1945595

Summary: [FTBFS] qt5-qtwebgine fails to build in rawhide due to glibc SIGSTKSZ change
Product: [Fedora] Fedora Reporter: Jonathan Wakely <jwakely>
Component: qt5-qtwebengineAssignee: Rex Dieter <rdieter>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: kde-sig, kevin, rdieter
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-25 14:16:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1959319    

Description Jonathan Wakely 2021-04-01 11:10:54 UTC
Description of problem:

Fails to build from source.

Version-Release number of selected component (if applicable):

qt5-qtwebengine-5.15.2-9.fc35

How reproducible:

always

Steps to Reproduce:
1. fedpkg build

Actual results:

../../3rdparty/chromium/third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.cc: In function 'void google_breakpad::{anonymous}::InstallAlternateStackLocked()':
../../3rdparty/chromium/third_party/breakpad/breakpad/src/client/linux/handler/exception_handler.cc:141:65: error: no matching function for call to 'max(int, long int)'
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                                                 ^

This code is just incorrect to assume that SIGSTKSZ has type int, nothing in POSIX says that's required to be true. It could use:

 static const unsigned kSigStackSize = std::max<unsigned>(16384, SIGSTKSZ);

But there's probably already an upstream fix.

Comment 1 Rex Dieter 2021-06-16 14:40:23 UTC
Added the workaround, now looks like another FTBFS

../../3rdparty/chromium/base/i18n/string_compare.cc: In function 'UCollationResult base::i18n::CompareString16WithCollator(const icu_69::Collator&, base::StringPiece16, base::StringPiece16)':
../../3rdparty/chromium/base/i18n/string_compare.cc:21:26: error: 'FALSE' was not declared in this scope
   21 |       icu::UnicodeString(FALSE, lhs.data(), static_cast<int>(lhs.length())),

...

../../3rdparty/chromium/base/i18n/time_formatting.cc: In function 'bool base::TimeDurationFormatWithSeconds(base::TimeDelta, base::DurationFormatWidth, base::string16*)':
../../3rdparty/chromium/base/i18n/time_formatting.cc:239:31: error: 'TRUE' was not declared in this scope
  239 |   return U_SUCCESS(status) == TRUE;

Comment 2 Rex Dieter 2021-06-24 17:07:17 UTC
Still banging away at this, 2 pronged attack:
* get 5.15.2 building asap (latest issue patched, building... pending any new ftbfs issues)
* working on 5.15.5, making good progress, maybe a day or 2 away

Comment 3 Kevin Kofler 2021-06-24 20:44:30 UTC
Great, thanks!

Comment 4 Rex Dieter 2021-06-25 14:16:53 UTC
As the particular issue referenced here is fixed (workaround), closing in favor of general FTBFS bug #1959319

Comment 5 Rex Dieter 2021-06-25 14:17:14 UTC

*** This bug has been marked as a duplicate of bug 1959319 ***