Bug 194575

Summary: Misspelled gen_require macro in example, policygentool, and policies
Product: [Fedora] Fedora Reporter: Hans Ulrich Niedermann <rhbugs>
Component: selinux-policyAssignee: Daniel Walsh <dwalsh>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5CC: dwalsh
Target Milestone: ---Keywords: SELinux
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.2.47-3.fc5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-11 12:26:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Hans Ulrich Niedermann 2006-06-14 07:02:31 UTC
Description of problem:

  Several files in /usr/share/selinux/devel contain a misspelled
  version of gen_require: "gen_requires" with a trailing "s".

  This causes policy templates generated by policygentool and
  the example.{fc,if,te} policy to be broken from the start.

Version-Release number of selected component (if applicable):

  selinux-policy-2.2.40-1.fc5

How reproducible:

  Every time.

Steps to Reproduce:
1. Run "grep -rl 'gen_requires' /usr/share/selinux/devel"

Actual results:

  /usr/share/selinux/devel/include/system/xen.if
  /usr/share/selinux/devel/include/services/tor.if
  /usr/share/selinux/devel/example.if
  /usr/share/selinux/devel/policygentool

Expected results:

  Empty output.

Additional info:

  While you're at it, do you mind fixing the broken symlink 
  /usr/share/selinux/devel/include pointing to ../devel/include
  which does not exist, while it most probably should point to
  ../../devel/include or ../include or ./ which do exist?

Comment 1 Hans Ulrich Niedermann 2006-06-14 07:03:46 UTC
Admittedly, I have no idea whether that broken symlink is actually needed by
anything.

Comment 2 Hans Ulrich Niedermann 2006-06-15 00:26:02 UTC
The issues persist in selinux-policy-2.2.43-4.fc5:

$ grep -rl gen_requires /usr/share/selinux/devel
grep: /usr/share/selinux/devel/include/include: No such file or directory
/usr/share/selinux/devel/include/system/xen.if
/usr/share/selinux/devel/include/services/tor.if
/usr/share/selinux/devel/example.if
/usr/share/selinux/devel/policygentool

$ grep -r gen_requires /usr/share/selinux/devel
grep: /usr/share/selinux/devel/include/include: No such file or directory
/usr/share/selinux/devel/include/system/xen.if: gen_requires(`
/usr/share/selinux/devel/include/system/xen.if: gen_requires(`
/usr/share/selinux/devel/include/services/tor.if:       gen_requires(`
/usr/share/selinux/devel/example.if:    gen_requires(`
/usr/share/selinux/devel/example.if:    gen_requires(`
/usr/share/selinux/devel/policygentool: gen_requires(`

Comment 3 Daniel Walsh 2006-06-15 19:31:11 UTC
Fixed in 2.2.47-3.fc5

Comment 4 Hans Ulrich Niedermann 2006-07-10 21:32:26 UTC
2.2.47-3.fc5 has arrived in FC5/-updates, so we may now close this bug?