Bug 1945869
| Summary: | Restore: rear doesn't create the EFI entry when software raid is used | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Renaud Métrich <rmetrich> | ||||
| Component: | rear | Assignee: | Pavel Cahyna <pcahyna> | ||||
| Status: | CLOSED ERRATA | QA Contact: | David Jež <djez> | ||||
| Severity: | high | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 7.9 | CC: | bwelterl, djez, fkrska, jreznik, ovasik, pcahyna | ||||
| Target Milestone: | rc | Keywords: | ZStream | ||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | rear-2.4-14.el7_9 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1958222 (view as bug list) | Environment: | |||||
| Last Closed: | 2022-01-11 17:36:05 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1958222, 1973448 | ||||||
| Attachments: |
|
||||||
See also https://github.com/rear/rear/issues/2595. On ReaR 2.6, the error is detected, because of *LogPrintError* being used instead of *LogIfError* (In reply to Renaud Métrich from comment #1) > See also https://github.com/rear/rear/issues/2595. > On ReaR 2.6, the error is detected, because of *LogPrintError* being used > instead of *LogIfError* With ReaR 2.6 and CentOS 7, I noticed another strange behavior though: ReaR wants to use \EFI\centos\grubx64.efi as the bootloader, although the system is currently using \EFI\centos\shimx64.efi Yes, it's because ReaR doesn't take care of Secure Boot possibility at all. You need to set SECURE_BOOT_BOOTLOADER manually. Can you please attach the configuration file (or at least the parts that are relevant for booting, like SECURE_BOOT_BOOTLOADER ? ) /etc/rear/local.conf: -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- SECURE_BOOT_BOOTLOADER="/boot/efi/EFI/redhat/shimx64.efi" BACKUP=NETFS OUTPUT_URL=nfs://192.168.122.1/home/rmetrich/REAR BACKUP_URL=nfs://192.168.122.1/home/rmetrich/REAR PROGS+=( strace ) -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- Kickstart used to create the system in softraid attached. Created attachment 1774066 [details]
Software Raid kickstart
Here's my attempt at a fix: https://github.com/rear/rear/pull/2608. Please review. Note though that I haven't tested with the SECURE_BOOT_BOOTLOADER setting yet, and finalize/Linux-i386/610_EFISTUB_run_efibootmgr.sh needs the same fix. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (rear bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2022:0069 |
Description of problem: Restoring a system having a software raid for /boot/efi, ReaR doesn't create the EFI entry, nor prints an error, even though an error pops up. ReaR output: -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- # rear recover [...] Patching file 'boot/efi/EFI/redhat/grub.cfg' Running mkinitrd... Updated initrd with new drivers for kernel 3.10.0-1160.21.1.el7.x86_64. Running mkinitrd... Updated initrd with new drivers for kernel 3.10.0-1160.el7.x86_64. Finished recovering your system. You can explore it under '/mnt/local'. Exiting rear recover (PID 445) and its descendant processes Running exit tasks -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- Log: (showing an error) -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- # grep -w efibootmgr /var/log/rear/rear-*.log 2021-04-02 12:34:48.092498680 efibootmgr --create --gpt --disk /dev/md --part 125 --write-signature --label "RedHatEnterpriseServer 7" --loader "\EFI\redhat\shimx64.efi" 2021-04-02 12:34:48.096125963 Problem occurred with creating an efibootmgr entry -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- The issue is due to the code /usr/share/rear/finalize/Linux-i386/630_run_efibootmgr.sh not supporting Software Raid at all: -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- 9 Dev=$( get_device_name $BootEfiDev ) # /dev/sda1 or /dev/mapper/vol34_part2 or /dev/mapper/mpath99p4 10 ParNr=$( get_partition_number $Dev ) # 1 (must anyway be a low nr <9) 11 Disk=$( echo ${Dev%$ParNr} ) # /dev/sda or /dev/mapper/vol34_part or /dev/mapper/mpath99p -------- 8< ---------------- 8< ---------------- 8< ---------------- 8< -------- Here above we have $BootEfiDev == /dev/md125. This ends up trying to open /dev/md (which doesn't exist). With Software Raid, one of the members should be used instead, e.g. /dev/vda2. The fact that no log is displayed is very problematic, it may end up in a Can't boot case. Version-Release number of selected component (if applicable): 2.4 and Upstream one How reproducible: Always Steps to Reproduce: 1. Install a VM with 2 disks in Software Raid 2. Take a backup 3. Try recovering