Bug 1945916
| Summary: | Foreman maintain service status command returns non "0" exit code due to some invalid services like "dynflow-sidekiq@orchestrator.yml.rpmsave, dynflow-sidekiq@worker.yml.rpmsave" | |||
|---|---|---|---|---|
| Product: | Red Hat Satellite | Reporter: | Ashish Humbe <ahumbe> | |
| Component: | Satellite Maintain | Assignee: | Anurag Patel <apatel> | |
| Status: | CLOSED ERRATA | QA Contact: | Gaurav Talreja <gtalreja> | |
| Severity: | high | Docs Contact: | ||
| Priority: | high | |||
| Version: | 6.8.0 | CC: | apatel, aruzicka, aupadhye, egolov, ehelms, jjeffers, kgaikwad | |
| Target Milestone: | 6.9.3 | Keywords: | Regression, Triaged | |
| Target Release: | Unused | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | rubygem-foreman_maintain-0.7.10 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1962853 (view as bug list) | Environment: | ||
| Last Closed: | 2021-07-01 14:58:46 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
Trivial (untested) patch that should fix this issue:
% git diff | cat
diff --git definitions/features/dynflow_sidekiq.rb definitions/features/dynflow_sidekiq.rb
index 5d2f3d5..6169451 100644
--- definitions/features/dynflow_sidekiq.rb
+++ definitions/features/dynflow_sidekiq.rb
@@ -37,6 +37,6 @@ class Features::DynflowSidekiq < ForemanMaintain::Feature
end
def configured_instances
- Dir['/etc/foreman/dynflow/*'].map { |config| File.basename(config, '.yml') }
+ Dir['/etc/foreman/dynflow/*.yml'].map { |config| File.basename(config, '.yml') }
end
end
Created redmine issue https://projects.theforeman.org/issues/32292 from this bug Upstream bug assigned to apatel Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/32292 has been resolved. Hi, any specific reason to move the target milestone from 6.9.3 to 6.10.0? and Devel Whiteboard also has snap_6.10.0_2.0, is it right? As there exists a clone BZ#1962853 which has targetted for 6.10.0 already or should we mark this clone BZ as DUPLICATE? Thanks, Gaurav Talreja @ehelm Eric, I see this was moved to 6.10 - was the intention to move it off 6.9.3? Eric, For 6.10, the correct bugzilla is the clone bug 1962853 and it did get moved to ON_QA. I am moving this one back to 6.9.3; otherwise, it may get missed on the zstream. I am also moving the state back to POST as I assume that is correct for 6.9.z; however, adding NEEDINFO so that you can keep me honest. Thanks! Verified.
Tested on Satellite 6.9.3 Snap 2.0
Version: rubygem-foreman_maintain-0.7.10-1.el7sat.noarch
Setup:
1. Have any backup .rpmsave file in /etc/foreman/dynflow/
# ls /etc/foreman/dynflow/
orchestrator.yml test_bz.yml.rpmsave worker-1.yml worker-hosts-queue-1.yml
Steps:
1. foreman-maintain service status -b
Observation:
service-status doesn't pick up any backup files like *.rpmsave, which don't exist as services.
Also, any other files with extension .yml that don't pick up by service-status, which fail eventually.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Satellite Maintenance 6.9.3 Async Bug Fix Update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2021:2635 |
Description of problem: / All services displayed [FAIL] Some services are not running (dynflow-sidekiq.rpmsave, dynflow-sidekiq.rpmsave) -------------------------------------------------------------------------------- Scenario [Status Services] failed. The following steps ended up in failing state: [service-status] Resolve the failed steps and rerun the command. In case the failures are false positives, use --whitelist="service-status" # echo $? 1 Here while checking the status of sidekiq instance services we are referring "orchestrator.yml.rpmsave" and "worker.yml.rpmsave" files / displaying dynflow-sidekiq.rpmsave ● dynflow-sidekiq.rpmsave.service - Foreman jobs daemon - orchestrator.yml.rpmsave on sidekiq Loaded: loaded (/usr/lib/systemd/system/dynflow-sidekiq@.service; enabled; vendor preset: disabled) Active: failed (Result: start-limit) since Fri 2021-04-02 22:18:55 IST; 2min 49s ago Docs: https://theforeman.org Process: 15206 ExecStart=/usr/libexec/foreman/sidekiq-selinux -e ${RAILS_ENV} -r ${DYNFLOW_SIDEKIQ_SCRIPT} -C /etc/foreman/dynflow/%i.yml (code=exited, status=1/FAILURE) Main PID: 15206 (code=exited, status=1/FAILURE) / displaying dynflow-sidekiq.rpmsave ● dynflow-sidekiq.rpmsave.service - Foreman jobs daemon - worker.yml.rpmsave on sidekiq Loaded: loaded (/usr/lib/systemd/system/dynflow-sidekiq@.service; enabled; vendor preset: disabled) Active: failed (Result: start-limit) since Fri 2021-04-02 22:18:55 IST; 2min 49s ago Docs: https://theforeman.org Process: 15205 ExecStart=/usr/libexec/foreman/sidekiq-selinux -e ${RAILS_ENV} -r ${DYNFLOW_SIDEKIQ_SCRIPT} -C /etc/foreman/dynflow/%i.yml (code=exited, status=1/FAILURE) Main PID: 15205 (code=exited, status=1/FAILURE) So the exit code is returned as "1"