Bug 1946540

Summary:	auth operator: only configure webhook authenticators for internal auth when oauth-apiserver pods are ready
Product:	OpenShift Container Platform	Reporter:	Standa Laznicka <slaznick>
Component:	apiserver-auth	Assignee:	Standa Laznicka <slaznick>
Status:	CLOSED ERRATA	QA Contact:	liyao
Severity:	high	Docs Contact:
Priority:	high
Version:	4.8	CC:	aos-bugs, mfojtik, sttts
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:57:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Standa Laznicka 2021-04-06 11:28:26 UTC

Description of problem:
In 4.8, the authentication operator configures authentication.spec.webhookTokenAuthenticator, which in turn causes kube-apiserver to rollout with webhook authentication configured towards the oauth-apiservers. However, during upgrade, the configuration event might precede the oauth-apiservers to be fully rolled out, and so authentication may not work properly.

Make sure the authentication.spec.webhookTokenAuthenticator is not set when there are still some oauth-apiserver replicas that are not ready during an update.

Also make sure that once kube-apiserver observes the webhook authenticators configuration, configuring oauth.spec.tokenConfig.accessTokenInactivityTimeout causes no new kube-apiserver rollouts since this configuration no longer should have any effect on kube-apiserver.

Version-Release number of selected component (if applicable):
4.8

How reproducible:
sometimes

Steps to Reproduce, Actual results, Expected results:
described above

Comment 1 Stefan Schimanski 2021-04-14 12:33:09 UTC

As discussed in Slack, this is a blocker.

Comment 3 Standa Laznicka 2021-04-20 09:08:44 UTC

moving back to ASSIGNED, the original patch was wrong and would prevent webhook authenticators from being configured

Comment 9 errata-xmlrpc 2021-07-27 22:57:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438