Bug 1946688

Summary: fedpkg import removing <package name>.rpmlintrc.
Product: [Fedora] Fedora Reporter: Jun Aruga <jaruga>
Component: rpkgAssignee: Aditya Bisoi <abisoi>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cqi, dennis, jkeating, lsedlar, onosek, otto.liljalaakso, s
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rpkg-1.63-2.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-09-09 17:45:19 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jun Aruga 2021-04-06 16:49:51 UTC
Description of problem:

`fedpkg import` removing `<package name>.rpmlintrc`.

I think the `<package name>.rpmlintrc` is used by Zuul CI.
However this file is removed by `fedpkg import ..`. It's not convenient.
Could you add the file to a list of the files skipped by `fedpkg import ..`?


Version-Release number of selected component (if applicable):

```
$ rpm -q fedpkg
fedpkg-1.40-5.fc33.noarc
```

How reproducible:


Steps to Reproduce:
1. fedpkg co simde
2. cd simde
3. fedpkg srpm
4. fedpkg import simde-0.7.2-1.git22609d4.fc35.src.rpm

Actual results:

```
$ fedpkg import simde-0.7.2-1.git22609d4.fc35.src.rpm
Removing no longer used file: simde.rpmlintrc
...

$ git status
On branch rawhide
Your branch is up to date with 'origin/rawhide'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	deleted:    simde.rpmlintrc
...
```

Expected results:
Do not remove simde.rpmlintrc (<package name>.rpmlintrc).

Additional info:

Comment 1 Jun Aruga 2021-04-14 10:19:56 UTC
Ping?

I think other packages having the <package>.rpmlintrc file also are affected by this issue.

Comment 2 Ondřej Nosek 2021-04-14 10:51:11 UTC
This is currently in progress.

Comment 3 Jun Aruga 2021-04-14 12:43:04 UTC
Oh thanks!! I am looking forward to seeing the updated version!

Comment 4 Ben Cotton 2021-08-10 12:58:00 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 5 Jun Aruga 2021-08-11 10:39:11 UTC
It still happens on Fedora 34.

```
$ cat /etc/fedora-release 
Fedora release 34 (Thirty Four)

$ rpm -q fedpkg
fedpkg-1.40-6.fc34.noarch

$ pwd
/home/jaruga/fed/simde

$ fedpkg import simde-0.7.3-1.git3378ab3.fc36.src.rpm
Removing no longer used file: simde.rpmlintrc
Could not execute import_srpm: (52, 'Empty reply from server')
```

The `Could not execute import_srpm: (52, 'Empty reply from server')` is not related to this issue.

Comment 6 Fedora Update System 2021-08-25 10:26:51 UTC
FEDORA-EPEL-2021-4b1bb0ee48 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-4b1bb0ee48

Comment 7 Fedora Update System 2021-08-25 10:30:09 UTC
FEDORA-2021-20e5f8a6b8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

Comment 8 Fedora Update System 2021-08-25 20:50:55 UTC
FEDORA-2021-20e5f8a6b8 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-20e5f8a6b8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Jun Aruga 2021-08-26 09:05:05 UTC
Thanks for fixing it.
I am not sure why a comment for Fedora 34 by Bodhi system is not written here. But I could find the actual URL.
https://bodhi.fedoraproject.org/updates/?packages=fedpkg
https://bodhi.fedoraproject.org/updates/FEDORA-2021-55652a7b38

Comment 10 Ondřej Nosek 2021-08-26 09:12:16 UTC
Yes, it is fixed in every supported fedpkg's distribution. I didn't want to spam e-mails. It produces a number of messages when BZ is linked in the Bodhi. I only linked it with f33.

Comment 11 Fedora Update System 2021-09-01 12:48:49 UTC
FEDORA-2021-20e5f8a6b8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

Comment 12 Fedora Update System 2021-09-01 20:21:14 UTC
FEDORA-2021-20e5f8a6b8 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-20e5f8a6b8`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-20e5f8a6b8

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2021-09-09 17:45:19 UTC
FEDORA-2021-20e5f8a6b8 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.