Bug 1946893

Summary:	the error messages are inconsistent in DNS status conditions if the default service IP is taken
Product:	OpenShift Container Platform	Reporter:	Hongan Li <hongli>
Component:	Networking	Assignee:	Miciah Dashiel Butler Masters <mmasters>
Networking sub component:	DNS	QA Contact:	jechen <jechen>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	amcdermo, aos-bugs
Version:	4.8
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:57:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hongan Li 2021-04-07 07:43:51 UTC

Description of problem:
If the default service IP (172.30.0.10) is taken, the error message "No IP assigned to DNS service" was shown for Degraded/Progressing/Available status conditions before. 
after the commit https://github.com/openshift/cluster-dns-operator/pull/209/commits/b77fc3685bb59afd0b3a0ec5d3a325d78e149727, the error messages was updated to "No IP address is assigned to the DNS service" for Degraded and Progressing conditions, but "The DNS service has no cluster IP address" for Available condition.

Version-Release number of selected component (if applicable):
4.8.0-0.nightly-2021-04-06-162113

How reproducible:
100%

Steps to Reproduce:
1. oc -n openshift-dns-operator delete pod --all && oc -n openshift-dns delete svc dns-default && oc create -f svc-ip-taken.yaml
2. oc get dns.operator/default -oyaml
3.

Actual results:
<---snip--->
status:
  clusterDomain: cluster.local
  clusterIP: ""
  conditions:
  - lastTransitionTime: "2021-04-07T02:12:21Z"
    message: No IP address is assigned to the DNS service.
    type: Degraded
  - lastTransitionTime: "2021-04-07T02:12:55Z"
    message: |-
      No IP address is assigned to the DNS service.
    type: Progressing
  - lastTransitionTime: "2021-04-07T02:12:21Z"
    message: The DNS service has no cluster IP address.
    type: Available

Expected results:
better to use same error messages for the three conditions. 

Additional info:

Comment 2 jechen 2021-04-19 11:28:43 UTC

verified in 4.8.0-0.nightly-2021-04-18-203506

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.8.0-0.nightly-2021-04-18-203506   True        False         143m    Error while reconciling 4.8.0-0.nightly-2021-04-18-203506: the cluster operator ingress has not yet successfully rolled out



$ oc -n openshift-dns-operator delete pod --all && oc -n openshift-dns delete svc dns-default && oc create -f /home/jechen/automation-work/verification-tests/features/tierN/testdata/routing/dns/svc-37912.yaml
pod "dns-operator-df84494db-n5mjc" deleted
service "dns-default" deleted
service/svc-37912 created
$ oc get dns.operator/default -oyaml
<---snip--->
status:
  clusterDomain: cluster.local
  clusterIP: ""
  conditions:
  - lastTransitionTime: "2021-04-19T11:22:30Z"
    message: No IP address is assigned to the DNS service.
    reason: NoService
    status: "True"
    type: Degraded
  - lastTransitionTime: "2021-04-19T11:22:32Z"
    message: |-
      No IP address is assigned to the DNS service.
      Have DNS daemonset with node selector map[kubernetes.io/os:linux], want map[].
      Have DNS daemonset with tolerations [{node-role.kubernetes.io/master Exists   <nil>}], want [].
      Have 5 available node-resolver pods, want 6.
    reason: Reconciling
    status: "True"
    type: Progressing
  - lastTransitionTime: "2021-04-19T11:22:30Z"
    message: No IP address is assigned to the DNS service.
    reason: NoService
    status: "False"
    type: Available


verified error messages are same for 3 conditions.

Comment 5 errata-xmlrpc 2021-07-27 22:57:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438