Bug 1946939

I built (rhel-9.0 code on a Fedora 33) qemu-kvm without SPICE and QXL,
and tried to create a new VM from iso. The default configuration is with
SPICE and QXL ("Customize configuration before Installation").
"Begin Installation" failed with errors such as:
"Unable to complete install: 'unsupported configuration: spice graphics
 are not supported with this QEMU'"

So possibly it's enough to change the default configuration such that it
does not fail for users and remove Requires from spec-file.

$ rpm -q qemu-kvm libvirt-daemon libvirt-client virt-manager
qemu-kvm-5.2.0-7.el9.0.1.uri3.x86_64
libvirt-daemon-6.6.0-5.fc33.x86_64
libvirt-client-6.6.0-5.fc33.x86_64
virt-manager-3.2.0-2.fc33.noarch

Hi Pavel,
When I test with the latest virt-viewer package, spice graphics is not supported.


Steps as follows:

Package version:

virt-viewer-10.0-1.el9.x86_64
virt-install-3.2.0-4.el9.noarch
qemu-kvm-5.2.0-15.el9.x86_64
libvirt-7.0.0-6.el9.x86_64


1. Create a new vm by virt-install command.
# virt-install --memory 4096 --disk /var/lib/libvirt/images/vm1.img,size=9 --location http://download.eng.pek2.redhat.com/rhel-9/composes/RHEL-9/RHEL-9.0.0-20210421.d.2/compose/BaseOS/x86_64/os 


Actual results:
Failed to connect to vm console by virt-viewer, and an error message window pops up: 
=================================================================================
Failed to connect: unsupported graphic type 'spice'
=================================================================================

Expected results:
virt-install cmd should set vnc as the default graphics type since Spice removal from rhel9.

(In reply to zhoujunqin from comment #2)
> Hi Pavel,
> When I test with the latest virt-viewer package, spice graphics is not
> supported.
> 
> 
> Steps as follows:
> 
> Package version:
> 
> virt-viewer-10.0-1.el9.x86_64
> virt-install-3.2.0-4.el9.noarch
> qemu-kvm-5.2.0-15.el9.x86_64
> libvirt-7.0.0-6.el9.x86_64
> 
> 
> 1. Create a new vm by virt-install command.
> # virt-install --memory 4096 --disk /var/lib/libvirt/images/vm1.img,size=9
> --location
> http://download.eng.pek2.redhat.com/rhel-9/composes/RHEL-9/RHEL-9.0.0-
> 20210421.d.2/compose/BaseOS/x86_64/os 
> 
> 
> Actual results:
> Failed to connect to vm console by virt-viewer, and an error message window
> pops up: 
> =============================================================================
> ====
> Failed to connect: unsupported graphic type 'spice'
> =============================================================================
> ====
> 
> Expected results:
> virt-install cmd should set vnc as the default graphics type since Spice
> removal from rhel9.

Hi Junqin,

that is correct, we need to add RHEL-only patch to use VNC by default if spice
is not available.

(In reply to Pavel Hrdina from comment #3)
> (In reply to zhoujunqin from comment #2)
> > Hi Pavel,
> > When I test with the latest virt-viewer package, spice graphics is not
> > supported.
> > 
> > 
> > Steps as follows:
> > 
> > Package version:
> > 
> > virt-viewer-10.0-1.el9.x86_64
> > virt-install-3.2.0-4.el9.noarch
> > qemu-kvm-5.2.0-15.el9.x86_64
> > libvirt-7.0.0-6.el9.x86_64
> > 
> > 
> > 1. Create a new vm by virt-install command.
> > # virt-install --memory 4096 --disk /var/lib/libvirt/images/vm1.img,size=9
> > --location
> > http://download.eng.pek2.redhat.com/rhel-9/composes/RHEL-9/RHEL-9.0.0-
> > 20210421.d.2/compose/BaseOS/x86_64/os 
> > 
> > 
> > Actual results:
> > Failed to connect to vm console by virt-viewer, and an error message window
> > pops up: 
> > =============================================================================
> > ====
> > Failed to connect: unsupported graphic type 'spice'
> > =============================================================================
> > ====
> > 
> > Expected results:
> > virt-install cmd should set vnc as the default graphics type since Spice
> > removal from rhel9.
> 
> Hi Junqin,
> 
> that is correct, we need to add RHEL-only patch to use VNC by default if
> spice
> is not available.

Hi Pavel,
Got it, thanks for your reply.
I will keep an eye on the fix of virt-install, thanks.

Best Regards,
Juzhou.

If we just care about virt-install and friends, adding `./setup.py configure --default-graphics=vnc` to the spec file should mostly do it I think.

Teaching virt-manager to handle non-spice default, and cope with lack of spice client, will be more work, but that may not be relevant for RHEL9

Instead of adding new setup.py option called --default-graphics we can reuse the output of libvirt domcapabilities where libvirt already reports if spice is available or not.

`./setup.py configure --default-graphics` is pre-existing.

You're right we should be using domcapabilities to check reported graphics types (we currently aren't in virt-install). But checking domcapabilities is not the whole picture. That tells us whether the virt host supports spice. If RHEL9 virt-install is talking to RHEL8 libvirt, RHEL8 libvirt reports spice is supportd, but the client host does not support spice, so we will still want to default to VNC so the client has a chance to connect. It's pretty messy.

Agreed that it's a mess. There is basically no way how to make the spice removal seamless for users if we take into account remote connection and different OSes. For example virt-viewer would not be able to connect to existing VMs on RHEL8 as they will most likely have spice only. If we would pick VNC as default in this situation it would be inconsistent on the RHEL8 host. Now if we take into account that that RHEL8 host may be managed by other users with RHEL8 or even Fedora or other distributions where they would be able to use SPICE it would be a regression feature wise for these users.

Regardless of what we do the situation is doomed and the result will be broken for some users. I honestly don't know which approach would be better but I guess we will have to use the `--default-graphics` configure option as well to make it somehow work for most users.

*** Bug 1969952 has been marked as a duplicate of this bug. ***

Reproduce this issue as Comment 2 said.

Then test with the latest packages:
virt-manager-3.2.0-5.el9.noarch
virt-install-3.2.0-5.el9.noarch
qemu-kvm-6.0.0-6.el9.x86_64
libvirt-7.4.0-1.el9.x86_64

Steps:
1. New virt-manager rpm can be installed successfully.

# yum install virt-manager
Updating Subscription Management repositories.
Unable to read consumer identity

This system is not registered with an entitlement server. You can use subscription-manager to register.

Last metadata expiration check: 2:41:34 ago on Thu 24 Jun 2021 04:45:57 AM EDT.
Dependencies resolved.
====================================================================================================
 Package                  Architecture       Version                   Repository              Size
====================================================================================================
Installing:
 virt-manager             noarch             3.2.0-5.el9               libvirt_ci             539 k

Transaction Summary
====================================================================================================
Install  1 Package

Total download size: 539 k
Installed size: 2.9 M
Is this ok [y/N]: y
Downloading Packages:
virt-manager-3.2.0-5.el9.noarch.rpm                                 147 kB/s | 539 kB     00:03    
----------------------------------------------------------------------------------------------------
Total                                                               147 kB/s | 539 kB     00:03     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                            1/1 
  Installing       : virt-manager-3.2.0-5.el9.noarch                                            1/1 
  Running scriptlet: virt-manager-3.2.0-5.el9.noarch                                            1/1 
  Verifying        : virt-manager-3.2.0-5.el9.noarch                                            1/1 
Installed products updated.

Installed:
  virt-manager-3.2.0-5.el9.noarch                                                                   

Complete!

2. Download the package virt-manager-3.2.0-5.el9.src.rpm and extrat it,
Check the file virt-manager.spec, "Requires: spice-gtk3" has removed.

$ grep -nr 'spice-gtk3' virt-manager.spec

Result - No output is as expected.

3. Install a vm via virt-install command and finding the default graphics type is vnc.

# virt-install  --name testvm --memory 4096 --location http://download.eng.pek2.redhat.com/rhel-9/nightly/RHEL-9-Beta/latest-RHEL-9.0/compose/BaseOS/x86_64/os/  --nodisk --dry-run --print-xml
...
    <graphics type="vnc" port="-1"/>
    <video>
      <model type="vga"/>
    </video>
...

As a summary, I add the Verified:Tested flag to this bug, thanks.

Based on Comment 17 and our automation jobs' test result[1], I move this bug from ON_QA to VERIFIED status, thanks.

[1]https://libvirt-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/view/virt-install/view/RHEL-9.0%20x86_64/