Bug 1947067
| Summary: | [Installer] Pick up upstream fix for installer console output | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | To Hung Sze <tsze> | ||||||
| Component: | Installer | Assignee: | Russell Teague <rteague> | ||||||
| Installer sub component: | openshift-installer | QA Contact: | To Hung Sze <tsze> | ||||||
| Status: | CLOSED ERRATA | Docs Contact: | |||||||
| Severity: | low | ||||||||
| Priority: | low | CC: | kevin.grigorenko, mstaeble | ||||||
| Version: | 4.8 | ||||||||
| Target Milestone: | --- | ||||||||
| Target Release: | 4.8.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Mac OS | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | No Doc Update | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-07-27 22:57:59 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
To Hung Sze
2021-04-07 15:21:03 UTC
Note that the upstream changes were made here: https://github.com/AlecAivazis/survey/issues/306 Created attachment 1769965 [details]
Attached picture illustrates the issue on Linux box
Please see original github posting for behaviors with Mac. iTerm and iTerm2 behave differently. Actually, problem can still be reproduced on Linux - probably depends on the width of terminal. See attached. Also, after the install-config is generated, if you resize the terminal, you can see "INFO Install-config created in: xxxx" is "attached" to the last line of pull-secret. Created attachment 1782854 [details]
Problem reproduced on Linux
I did some additional testing with another upstream fix using Fedora 34, https://github.com/AlecAivazis/survey/pull/353 Although it did fix the issue of out-of-order output, it seems to also miss a newline before the last INFO log output. Also, it may not be desired to truncate the '*' output as it could misrepresent the actual quantity of entered text. ### WITHOUT PATCH FROM PR353 ### > $ ./openshift-install create install-config ? SSH Public Key /home/rteague/.ssh/openshift-dev.pub ? Platform aws INFO Credentials loaded from the "openshift-dev" profile in file "/home/rteague/.aws/credentials" ? Region us-east-2 ? Base Domain devcluster.openshift.com ? Cluster Name rteague-test ? Pull Secret [? for help] ***************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************************INFO Install-Config created in: . ************************************************************************************************** ### WITH PATCH FROM PR353 ### > $ ./openshift-install create install-config ? SSH Public Key /home/rteague/.ssh/openshift-dev.pub ? Platform aws INFO Credentials loaded from the "openshift-dev" profile in file "/home/rteague/.aws/credentials" ? Region us-east-2 ? Base Domain devcluster.openshift.com ? Cluster Name rteague-test ? Pull Secret [? for help] ************************************************************************************************************************************INFO Install-Config created in: . Verified that installer now shows improvement especially when terminal is too narrow - when using up / down arrrows now doesn't display extra lines: INFO Credentials loaded from file "/home/tsze/.gcp/osServiceAccount.json" ? Project ID [Use arrows to move, enter to select, type to filter, ? for mo? Project ID OpenShift QE (openshift-qe) ? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more h? Region [Use arrows to move, enter to select, type to filter, ? for more help] asia-south1 (Mumbai, India) But original problem in https://github.com/openshift/installer/issues/4523 isn't fixed. Updated the title to reflect this - and closing. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438 More problem when terminal is not wide enough: When trying to run installer without the osServicePrincipal.json file, installer doesn't display all the entries already entered: ? SSH Public Key /home/tsze/.ssh/openshift-qe.pub DEBUG Fetching Base Domain... DEBUG Fetching Platform... DEBUG Generating Platform... ? Platform azure DEBUG Could not get an azure authorizer from file. Asking user to provide authentication info ? azure subscription id 53b8f551-f0fc-4bea-8cba-xxxxxxxxxxxx ? azure tenant id 6047c7e9-b2ad-488d-a54e-xxxxxxxxxxxx ? azure service principal client id [? for help] 0834ab38-3208-4ad8-bfff-xxxxxxxxxxxx hit enter and it becomes ? SSH Public Key /home/tsze/.ssh/openshift-qe.pub DEBUG Fetching Base Domain... DEBUG Fetching Platform... DEBUG Generating Platform... ? Platform azure DEBUG Could not get an azure authorizer from file. Asking user to provide authentication info ? azure subscription id 53b8f551-f0fc-4bea-8cba-xxxxxxxxxxxx ? azure service principal client id 0834ab38-3208-4ad8-bfff-xxxxxxxxxxxx ? azure service principal client secret [? for help] Note that 'tenant id' is not displayed anymore. |