Bug 1947182

Summary:	Widelands installed blocks upgrade to Fedora 34
Product:	[Fedora] Fedora	Reporter:	Torsten Casselt <blu2lz>
Component:	widelands	Assignee:	Hans de Goede <hdegoede>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	33	CC:	andymenderunix, hdegoede, karlikt, nphilipp
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	widelands-0-0.84.build21.fc33 widelands-0-0.84.build21.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-28 02:43:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Torsten Casselt 2021-04-07 20:42:51 UTC

Description of problem:

With Widelands installed the upgrade to Fedora 34 is not possible. Error message states that the file /usr/share/widelands/i18n/fonts/-Culmus conflicts between versions.
The changelog of the fc34 version in bodhi states “Unbundle Culmus fonts”, so I guess that is the problem.
The same version that hit stable in 34 was stopped by karma in 33 because of the upgrade error.

Version-Release number of selected component (if applicable):

widelands-0-0.80.build20.fc33 (somehow cannot find it in bodhi, only 79)

How reproducible:

Always.

Steps to Reproduce:
1. Install Widelands in Fedora 33
2. Try to upgrade to Fedora 34

Actual results:

Error, no upgrade possible.

Expected results:

Upgrade. :)

Additional info:

Stopped widelands build for Fedora 33:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-b985d33aac

Widelands build in stable in Fedora 34:
https://bodhi.fedoraproject.org/updates/FEDORA-2021-08852b7ddd

Comment 1 Torsten Casselt 2021-04-18 21:16:17 UTC

I looked at the packages and found the problem:

The package tries to replace /usr/share/widelands/i18n/fonts/Culmus with a symlink. (“Unbundle Culmus fonts”)

Please have a look at

https://docs.fedoraproject.org/en-US/packaging-guidelines/Directory_Replacement

to work around this.

Comment 2 Hans de Goede 2021-04-19 09:47:07 UTC

Torsten, thank you for your bug-report and thank you for digging a bit deeper into this.

In my experience it is better in cases like this to not replace the directory with a symlink, but instead keep the dir and replace the individual font files with symlinks. This avoids all the issues surrounding directory replacement.

I'll prepare an update for this.

Comment 3 Hans de Goede 2021-04-19 09:58:35 UTC

Ah I see now that widelands actually is the package where this replacement problem happened before, but then it was replacing a symlink with a directory and Andy Mender copied my work around for that. But in the Culmus case we did not have a symlink before, so the workaround is now actually causing a symlink.

So in this case we need to keep the dir (rather then keep the symlink). I can see how this is all somewhat confusing. I'll add a note the specfile about this while fixing this.

Comment 4 Fedora Update System 2021-04-19 17:16:43 UTC

FEDORA-2021-e64087307a has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-e64087307a

Comment 5 Fedora Update System 2021-04-19 18:40:06 UTC

FEDORA-2021-1379ae692c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-1379ae692c

Comment 6 Fedora Update System 2021-04-20 15:37:17 UTC

FEDORA-2021-1379ae692c has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-1379ae692c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1379ae692c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2021-04-20 22:25:15 UTC

FEDORA-2021-e64087307a has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-e64087307a`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-e64087307a

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-04-28 02:43:59 UTC

FEDORA-2021-1379ae692c has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Torsten Casselt 2021-04-30 19:09:23 UTC

Comment 10 Torsten Casselt 2021-04-30 19:14:09 UTC

Hi Hans,

thanks for caring and preparing an update! The update that is needed to fix the upgrade block to F34 is still in testing though:

https://bodhi.fedoraproject.org/updates/FEDORA-2021-e64087307a

I would have expected that this would hit stable as a 0-day update. It seems stuck to me. Could you explain why? I’m waiting for it to land to upgrade to F34.

Thanks!
Torsten

Comment 11 Hans de Goede 2021-04-30 22:17:10 UTC

Weird, I enabled auto stable based on both time in stable and on reaching 3+ karma, so it should have been pushed to stable.

Anyways I've pushed it manually now, so it should show up in the next batch of updates.

Note you can also upgrade widelands to the f33 version with the same fixes while still running f33 and then move to f34, that should work right away.

Comment 12 Fedora Update System 2021-05-01 02:57:11 UTC

FEDORA-2021-e64087307a has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.