Bug 1948092

Created attachment 1770811 [details]
File: anaconda-tb

Created attachment 1770812 [details]
File: anaconda.log

Created attachment 1770813 [details]
File: dbus.log

Created attachment 1770814 [details]
File: environ

Created attachment 1770815 [details]
File: journalctl

Created attachment 1770816 [details]
File: lsblk_output

Created attachment 1770817 [details]
File: lvm.log

Created attachment 1770818 [details]
File: nmcli_dev_list

Created attachment 1770819 [details]
File: os_info

Created attachment 1770820 [details]
File: program.log

Created attachment 1770821 [details]
File: storage.log

Ahh OK the /dev/vda device is 512 bytes in the VM! I skipped the g in the actual truncate command.

truncate -s 100 f34w-ext4.raw

Oops.

Proposed as a Blocker for 34-final by Fedora user chrismurphy using the blocker tracking app because:

 Beta:
When using both the installer-native and the blivet-gui-based custom partitioning flow, the installer must be able to: 
- Reject or disallow invalid disk and volume configurations without crashing.

Chris, does this also happen if you create 1M, 10M, 100M disk? Or does it happen just for extremely small (<1kB) disks?

From storage.log:

INFO:blivet:DiskLabel.parted_device returning None
DEBUG:blivet:get_format('disklabel') returning DiskLabel instance with object id 151
INFO:blivet:DiskLabel.parted_device returning None
INFO:blivet:DiskLabel.parted_device returning None
WARNING:dasbus.server.handler:The call org.fedoraproject.Anaconda.Modules.Storage.DeviceTree.Viewer.GetFormatTypeData has failed with an exception:
Traceback (most recent call last):
  File "/usr/lib/python3.9/site-packages/dasbus/server/handler.py", line 418, in _method_callback
    result = self._handle_call(
  File "/usr/lib/python3.9/site-packages/dasbus/server/handler.py", line 234, in _handle_call
    return handler(*parameters)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer_interface.py", line 89, in GetFormatTypeData
    return DeviceFormatData.to_structure(self.implementation.get_format_type_data(name))
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer.py", line 183, in get_format_type_data
    return self._get_format_data(fmt)
  File "/usr/lib64/python3.9/site-packages/pyanaconda/modules/storage/devicetree/viewer.py", line 195, in _get_format_data
    data.description = fmt.name or ""
  File "/usr/lib/python3.9/site-packages/blivet/threads.py", line 53, in run_with_lock
    return m(*args, **kwargs)
  File "/usr/lib/python3.9/site-packages/blivet/formats/disklabel.py", line 322, in name
    return _str % {"name": _(self._name), "type": self.label_type.upper()}
AttributeError: 'NoneType' object has no attribute 'upper'

It seems to be a duplicate of the bug 1945914. Reassigning to blivet.

Chris: I wasn't able to reproduce the issue with the storage configuration you described, but I agree with Vendy, this looks like a duplicate of 1945914, can you try with the updates image from this bug? https://vtrefny.fedorapeople.org/img/rhbz1945914.img

Discussed during the 2021-04-12 blocker review meeting: [1]

The decision to classify this bug was postponed:

"We agreed to delay this while we get more detail on exactly what the failure case is, and if it's a dupe of 1945914 (or at least fixed by the same change)."

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2021-04-12/f34-blocker-review.2021-04-12-16.02.log.txt

I can trigger the crash (4 for 4 attempts) if the raw backing file is 512 bytes or less. And with the updates.img in c17 it does not crash.

*** This bug has been marked as a duplicate of bug 1945914 ***