Bug 1948410

Summary:	[LSO] Local Storage Operator uses imagePullPolicy as "Always"
Product:	OpenShift Container Platform	Reporter:	Chao Yang <chaoyang>
Component:	Storage	Assignee:	melbeher
Storage sub component:	Local Storage Operator	QA Contact:	Chao Yang <chaoyang>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	aos-bugs, jsafrane, rojoseph
Version:	4.8
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:58:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Chao Yang 2021-04-12 06:56:29 UTC

Description of problem:
Local Storage Operator uses imagePullPolicy as "Always" 

Version-Release number of selected component (if applicable):
local-storage-operator.4.8.0-202104090329.p0
4.8.0-0.nightly-2021-04-09-222447

How reproducible:
Always

Steps to Reproduce:
1.Deploy Local Storage Operator
2.oc get deployment.apps/local-storage-operator -o json | jq .spec.template.spec.containers[].imagePullPolicy
"Always"

Actual results:
Local Storage Operator uses imagePullPolicy as "Always" 

Expected results:
Local Storage Operator uses imagePullPolicy as "IfNotPresent" 

Master Log:

Node Log (of failed PODs):

PV Dump:

PVC Dump:

StorageClass Dump (if StorageClass used by PV/PVC):

Additional info:

Comment 1 Rohan CJ 2021-04-12 07:01:12 UTC

Hi, can you elaborate on why ImagePullPolicy: Always is undesirable?

Comment 2 Jan Safranek 2021-04-19 15:17:34 UTC

I can't find the right document, but I think we have `ImagePullPolicy: IfNotPresent` for disconnected environment.

Comment 3 Chao Yang 2021-05-07 08:43:19 UTC

ImagePullPolicy: IfNotPresent should be better

Comment 4 melbeher 2021-05-12 17:02:20 UTC

Fix is created here  https://github.com/openshift/local-storage-operator/pull/231

Comment 6 Chao Yang 2021-05-17 05:49:38 UTC

oc get deployment.apps/local-storage-operator -o json | jq .spec.template.spec.containers[].imagePullPolicy
"IfNotPresent"
local-storage-operator.4.8.0-202105111002.p0

Comment 9 errata-xmlrpc 2021-07-27 22:58:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438