Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1948514

Summary:	[assisted operator][nmstate][4.8] ISO should not be created if InstallEnv references not found NMStateConfig
Product:	OpenShift Container Platform	Reporter:	nshidlin <nshidlin>
Component:	assisted-installer	Assignee:	Nir Magnezi <nmagnezi>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	aos-bugs, atraeger, fpercoco, mhrivnak, ohochman
Version:	4.8
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Hive
Fixed In Version:	OCP-Metal-v1.0.20.1	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-01-05 16:11:41 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description nshidlin 2021-04-12 10:42:08 UTC

Description of problem:
When generating an InstallEnv referencing non-existent nmStateConfigLabelSelector to ISO is simply generated without the nmstate configuration.

This is counter intuitive from the user perspective. If the user forgot or their automation failed to create the referenced NMStateConfig the ISO is generated with no indication to the user the ISO was generated without the nmstate configuration. 

Version-Release number of selected component (if applicable):
assisted-service-image: quay.io/ocpmetal/assisted-service:@sha256:809d0d863b7d0800a62ebddfa516b8a67adc8f0fcd114090bc2ea72f53edf4c4

Comment 1 Michael Filanov 2021-04-12 11:33:47 UTC

i remember that we talked about it but don't remember the conclusion, what should be the expected behavior in this case @atraeger @mhrivnak ?

Comment 2 Nir Magnezi 2021-04-25 10:05:04 UTC

Thank you for reporting this, Nir.
I recall past discussions around that topic.
I'll bring it up in tomorrows' sync meeting.

Comment 3 Michael Hrivnak 2021-04-29 17:31:53 UTC

The conclusion from the sync meeting was that lacking a way to know how many NMStateConfigs to expect, there's no way to safely wait for them. We need one of two things for correct behavior:
- the user created their NMStateConfigs before the InfraEnv
- The InfraEnv re-creates its ISO when new NMStateConfigs are found, and that automatically propagates to any agents that haven't yet started installing. (where we draw the line in the state machine is its own conversation)

Comment 4 Nir Magnezi 2021-05-04 12:15:47 UTC

Proposed the following doc update to reflect the conclusion Michael mentioned in comment#3: https://github.com/openshift/assisted-service/pull/1656

Comment 5 nshidlin 2021-05-06 08:10:50 UTC

Moving to verified according to DOC update in https://github.com/openshift/assisted-service/pull/1656

Comment 9 errata-xmlrpc 2022-01-05 16:11:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.8.25 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:5209