Bug 1948729

Summary: srtp_init() always returns srtp_err_status_cipher_fail
Product: [Fedora] Fedora Reporter: George Joseph <g.devel>
Component: libsrtpAssignee: Tom "spot" Callaway <spotrh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: urgent Docs Contact:
Priority: unspecified    
Version: 34CC: jsmith.fedora, spotrh, trevor.hemsley
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: libsrtp-2.3.0-6.fc34 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-24 20:12:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
srtp test program
none
Alows building against nss-3.63+ none

Description George Joseph 2021-04-12 20:17:48 UTC 
Created attachment 1771431 [details]
srtp test program

Description of problem:

srtp_init() always returns srtp_err_status_cipher_fail

Version-Release number of selected component (if applicable):


2.3.0-5.fc34

How reproducible:

Constant

Steps to Reproduce:
1. Create small test program that calls srtp_init().  Check the return code.
2.
3.

Actual results:

Return code is always srtp_err_status_cipher_fail

Expected results:

Return code is srtp_err_status_ok


Additional info:

libsrtp2 v2.3.0 compiled from source works fine.
Compile attach test program with
gcc -ggdb -o test_srtp -lsrtp2 test_srtp.c

Asterisk issue ID: https://issues.asterisk.org/jira/browse/ASTERISK-29387
Comment 1 George Joseph 2021-04-15 17:40:19 UTC 
Created attachment 1772232 [details]
Alows building against nss-3.63+

The issue turns out to be an incompatibility with nss-3.63 shipped with F34.  The attached patch adds NSS_PKCS11_2_0_COMPAT defines to 2 header files to enable the backward compatibility.  The same fix is already in the upstream github repo and is targeted for the next libsrtp release.
Comment 2 Fedora Update System 2021-04-15 18:17:00 UTC 
FEDORA-2021-9ac23c1745 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ac23c1745
Comment 3 Tom "spot" Callaway 2021-04-15 18:22:37 UTC 
Thank you so much for tracking down the fix here!
Comment 4 Fedora Update System 2021-04-15 19:29:23 UTC 
FEDORA-2021-9ac23c1745 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-9ac23c1745`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-9ac23c1745

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 5 Fedora Update System 2021-04-24 20:12:51 UTC 
FEDORA-2021-9ac23c1745 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 6 Trevor Hemsley 2023-11-01 00:01:37 UTC 
This bug is also present in RHEL 9.0 - 9.2's libsrtp and teh same patch applied to the source there fixes that too.