Bug 1949289

Summary: clevis-systemd is using ncat but has dependency set on nc but uses ncat
Product: Red Hat Enterprise Linux 8 Reporter: James Hartsock <hartsjc>
Component: clevisAssignee: Sergio Correia <scorreia>
Status: CLOSED ERRATA QA Contact: Martin Zelený <mzeleny>
Severity: medium Docs Contact: Khushbu Borole <kborole>
Priority: medium    
Version: 8.3CC: dapospis, mjahoda, mzeleny, orion, rsroka
Target Milestone: betaKeywords: Triaged
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: clevis-15-3.el8 Doc Type: Enhancement
Doc Text:
.`clevis-systemd` no longer depends on `nc` With this enhancement, the `clevis-systemd` package no longer depends on the `nc` package. The dependency did not work correctly when used with Extra Packages for Enterprise Linux (EPEL).
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 13:52:43 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description James Hartsock 2021-04-13 21:17:51 UTC
Description of problem:
clevis-systemd uses ncat in /usr/libexec/clevis-luks-askpass
However, the clevis-systemd RPM has dependency on nc


Not a big issue when only RHEL BaseOs & AppStream repos are in use; however, in EPEL the netcat RPM exists and it too provides nc, but NOT ncat binary clevis-systemd actually uses.


Version-Release number of selected component (if applicable):
clevis-systemd-13-3.el8

How reproducible:
100%

Steps to Reproduce:
1. Look at what the RPM requires

  # rpm -qp --requires rhel-8-for-x86_64-appstream-rpms/Packages/c/clevis- 
 systemd-13-3.el8.x86_64.rpm | head -n 4
  /bin/bash
  /bin/sh
  clevis-luks(x86-64) = 13-3.el8
  nc

2. Looking at script the RPM provides, can see clearly it uses ncat (not nc)

  # grep -n ncat /usr/libexec/clevis-luks-askpass
  60:            echo -n "+$pt" | ncat -U -u --send-only "$s"


3. And can see that nc is provided by both nmap-ncat (AppStream) & netcat (EPEL)

  # dnf --repo rhel-8-for-x86_64-baseos-rpms --repo rhel-8-for-x86_64-appstream-rpms --repo epel whatprovides nc | grep -v @System | grep -B1 Repo
netcat-1.217-3.el8.x86_64 : OpenBSD netcat to read and write data across 
  connections using TCP or UDP
  Repo        : epel
  --
  nmap-ncat-2:7.70-4.el8.x86_64 : Nmap's Netcat replacement
  Repo        : rhel-8-for-x86_64-appstream-rpms
  --
  nmap-ncat-2:7.70-5.el8.x86_64 : Nmap's Netcat replacement
  Repo        : rhel-8-for-x86_64-appstream-rpms


Actual results:
  With netcat from EPEL install (or even selected by dnf when both repos enabled) to meet the 'nc' require, clevis fails and are unable to boot/mount an NBDE system you just installed.

Expected results:
  The requires should match the binary it is using to make sure the actual required binary is installed


Additional info:

  Here can see just nc binary for netcat from EPEL
    # rpm -qp --list ./netcat-1.217-3.el8.x86_64.rpm  | grep bin/nc
    /usr/bin/nc


  And nmap-ncat provides 
    #  rpm -q --list nmap-ncat  | grep bin/nc
    /usr/bin/nc
    /usr/bin/ncat


  Looking at provides, pehaps best to set require on nmap-ncat ... since ncat isn't explicitly listed in provides?

    # rpm -q --provides nmap-ncat
    nc
    nc6
    nmap-ncat = 2:7.70-5.el8
    nmap-ncat(x86-64) = 2:7.70-5.el8

Comment 1 Sergio Correia 2021-04-13 21:47:59 UTC
(In reply to James Hartsock from comment #0)

[snip]

>   Looking at provides, pehaps best to set require on nmap-ncat ... since
> ncat isn't explicitly listed in provides?

This would make sense.

The latest clevis release upstream (v16) even dropped netcat altogether as a requirement, since systemd provides a utility that can do the task netcat was being used for and it's already available -- as this is a systemd unlocker.

Comment 2 James Hartsock 2021-04-13 22:00:42 UTC
(In reply to Sergio Correia from comment #1)

[snip]

> The latest clevis release upstream (v16) even dropped netcat altogether as a
> requirement, since systemd provides a utility that can do the task netcat
> was being used for and it's already available -- as this is a systemd
> unlocker.


Looks like this is link to your pull ... that should work too.
  https://github.com/latchset/clevis/pull/266

Comment 9 errata-xmlrpc 2022-05-10 13:52:43 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (clevis bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1857