Bug 1949611

Summary: module 'mtlogin' doesn't pass parameter 'passphrase' to the procedure 'login'
Product: [Fedora] Fedora EPEL Reporter: Ivan Lehtinen <ileht>
Component: rancidAssignee: Sven Lankes <sven>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: epel7CC: bennie.joubert, cra, david.brown, sven
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-09 03:34:01 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Ivan Lehtinen 2021-04-14 16:31:32 UTC 
Description of problem:
module 'mtlogin' doesn't pass parameter 'passphrase' to the procedure 'login'

Version-Release number of selected component (if applicable):
3.13

How reproducible:
try to use non-empty passphrase

Steps to Reproduce:
1. set up identity with non-empty passphrase
2. set up login parameters identity/passphrase
3. rancid doesn't log in to MikroTik

Actual results:
no login

Expected results:
successful login

Additional info:
I modified module 'mtlogin', the definition and the single call of the procedure 'login'.
Now it works.
Comment 1 Charles R. Anderson 2022-02-07 22:08:56 UTC 
Can you please attach the modified mtlogin here?  Even better would be to post your solution upstream or to the rancid-discuss list:

https://www.shrubbery.net/rancid/

Getting help

Please send problems/contributions/suggestions to rancid.

We have the standard mailing lists for those interested; rancid-announce and rancid-discuss. Subscribe by sending an email to rancid-<announce or discuss>-subscribe or by visiting the mailman page for each, at rancid-announce or rancid-discuss.

Thanks!
Comment 2 Ivan Lehtinen 2022-02-11 11:25:44 UTC 
The 'passphrase' parameter is present in the body of the 'login' procedure, it is only mistakenly omitted in the procedure declaration and procedure call. Only minor changes to the 'mtlogin' module are required, so I'm not attaching the entire module.

--- mtlogin.src	2022-02-11 14:16:25.684713149 +0300
+++ mtlogin	2021-04-14 17:57:35.000000000 +0300
@@ -386,7 +386,7 @@

 # Log into the router.
 # returns: 0 on success, 1 on failure
-proc login { router user userpswd passwd prompt cmethod cyphertype identfile } {
+proc login { router user userpswd passwd prompt cmethod cyphertype identfile passphrase } {
     global spawn_id in_proc do_command do_script
     global u_prompt p_prompt sshcmd telnetcmd
     set in_proc 1
@@ -704,7 +704,7 @@
     if { $do_cloginrcdbg > 0 } { continue; }

     # Login to the router
-    if {[login $router $ruser $userpswd $passwd $prompt $cmethod $cyphertype $identfile]} {
+    if {[login $router $ruser $userpswd $passwd $prompt $cmethod $cyphertype $identfile $passphrase]} {
 	incr exitval
 	continue
     }
Comment 3 Fedora Admin user for bugzilla script actions 2023-04-26 00:35:15 UTC 
This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component.
Comment 4 Troy Dawson 2024-07-09 03:34:01 UTC 
EPEL 7 entered end-of-life (EOL) status on 2024-06-30.\n\nEPEL 7 is no longer maintained, which means that it\nwill not receive any further security or bug fix updates.\n As a result we are closing this bug.