Bug 1950808
Summary: | cluster-samples-operator restarts approximately two times per day and logs too many same messages | |||
---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Gabe Montero <gmontero> | |
Component: | Samples | Assignee: | Gabe Montero <gmontero> | |
Status: | CLOSED ERRATA | QA Contact: | XiuJuan Wang <xiuwang> | |
Severity: | urgent | Docs Contact: | ||
Priority: | urgent | |||
Version: | 4.6 | CC: | adam.kaplan, gmontero, hfukumot, xiuwang | |
Target Milestone: | --- | |||
Target Release: | 4.7.z | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | Bug Fix | ||
Doc Text: |
Cause: based on the timing of the events it receives, the samples operator could end up breaking the contract with k8s SharedInformers an mutate the controller cache for the objects (Samples Config, Templates, Imagestreams) that it watches.
Consequence: In many cases, robustness in k8s kept thing OK, but we've now seen cases where this violation produced a panic in k8s when samples operator tried to updated the objects it watches.
Fix: Stop mutating the cache via better use of k8s DeepCopy prior to updates. Also adjusted when we copy config information from spec to status in the samples config CR instances.
Result: the samples operator no longer mutates its SharedInformer cache, and avoids panics in k8s when updating the objects it manages.
|
Story Points: | --- | |
Clone Of: | 1949481 | |||
: | 1950809 (view as bug list) | Environment: | ||
Last Closed: | 2021-05-04 19:50:50 UTC | Type: | --- | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | 1949481 | |||
Bug Blocks: | 1950809 |
Comment 6
errata-xmlrpc
2021-05-04 19:50:50 UTC
|