Bug 1951043

Summary: Start Pipeline Modal Parameters should accept empty string defaults
Product: OpenShift Container Platform Reporter: Andrew Ballantyne <aballant>
Component: Dev ConsoleAssignee: Andrew Ballantyne <aballant>
Status: CLOSED ERRATA QA Contact: Gajanan More <gamore>
Severity: medium Docs Contact: Srivaralakshmi Ramani <srr>
Priority: medium    
Version: 4.6CC: aos-bugs, gamore, hmishra, kjeeyar, nmukherj, ppitonak
Target Milestone: ---Flags: srr: needinfo-
srr: needinfo-
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Previously, if you created a pipeline with parameters that had empty strings, for example, `”`, the fields in the {product-title} web console would not accept the empty strings. The current release fixes this issue. Now, `”` is supported as a valid default property within the parameters section. (link:https://bugzilla.redhat.com/show_bug.cgi?id=1951043[*BZ#1951043*])
Story Points: ---
Clone Of:
: 1966275 (view as bug list) Environment:
Last Closed: 2021-07-27 23:01:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1966275    

Description Andrew Ballantyne 2021-04-19 13:24:58 UTC
Description of problem:

The Start Pipeline Modal does not respect an empty string ('') as a valid default although it is upstream. The UI should not make it a required field in the modal.

Version-Release number of selected component (if applicable):


How reproducible:
Always (create via YAML or CLI)


Steps to Reproduce:
1. Create a Pipeline with an empty string default value (see additional info for suggestions how to do it in the UI)
2. Using the actions (or "more options" menu on the list page) select "Start Pipeline"
3. Try to submit with a empty string default param without touching the field

Actual results:
We show * next to the parameters that don't have defaults. An empty string ('') is a falsy value and thus got confused as a no default provided. This is not valid upstream and needs to change.

Expected results:
Should be able to submit without updating any params that have defaults of an empty string ('').


Additional info:
The Pipeline Builder currently doesn't support this and our UI does not allow for empty strings. Will need UX to fix that portion, but the work around would be to use the Pipeline Builder entirely and then flip over to the YAML to set the default of a param to '' and then create via YAML.

Comment 1 Andrew Ballantyne 2021-04-19 13:38:26 UTC
Original discussion occurred on Google Chat, but I'm not sure I can link to the specific thread :(

Comment 2 Andrew Ballantyne 2021-04-19 13:40:51 UTC
This might be the best link I can get: https://chat.google.com/room/AAAApNTFPIc/aeqy5NztVhw

Comment 4 Karthik Jeeyar 2021-06-03 12:34:10 UTC
Verified on 4.8.0-0.nightly-2021-06-02-025513

Comment 9 errata-xmlrpc 2021-07-27 23:01:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438