Bug 1951495

Summary: Review Request: perl-Net-NBName - NetBIOS Name Service Requests
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Petr Pisar <ppisar>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, ppisar
Target Milestone: ---Flags: ppisar: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-11 00:53:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1950382    

Description Emmanuel Seyman 2021-04-20 09:32:35 UTC 
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Net-NBName/perl-Net-NBName.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Net-NBName/perl-Net-NBName-0.26-41.el7.src.rpm
Description:
Net::NBName is a class that allows you to perform simple NetBIOS Name
Service Requests in your Perl code. It performs these NetBIOS operations
over TCP/IP using Perl's built-in socket support.

Fedora Account System Username: eseyman
Comment 1 Emmanuel Seyman 2021-04-20 09:35:17 UTC 
FTR, perl-Net-NBName was orphaned on its EPEL7 branch back in 2016 and retired a while later.
I've been asked to revive it in bug #1950382 but this requires a re-review
Comment 2 Petr Pisar 2021-05-14 11:56:26 UTC 
URL and Source0 addresses are Ok.
Source0 archive (SHA-512: ff12f9265ff1dbdca5c592b6854dbad7eabf4ce9d68d054534924cc62759aff301e41b4892677b822c30735858542f76804b18ca1be62f8f8c7aaa1fc530a035) is original. Ok.
Summary verified from lib/Net/NBName.pm. Ok.
Description verified from lib/Net/NBName.pm. Ok.
License verified from README, lib/Net/NBName.pm, lib/Net/NBName/NodeStatus.pm, lib/Net/NBName/NodeStatus/RR.pm, lib/Net/NBName/NameQuery.pm, and lib/Net/NBName/NameQuery/RR.pm. Ok.
No XS code, noarch BuildArch is Ok.

Net::Netmask is not used at tests. Ok.

TODO: You could build-require perl-generators (it's in EPEL).
TODO: You could replace a sed call with perl to drop one dependency.
TODO: You could replace "find ... -exec rm -f {} ;" with "find ... -delete"

All tests pass. Ok.

$ rpmlint perl-Net-NBName.spec ../SRPMS/perl-Net-NBName-0.26-41.fc35.src.rpm ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm 
perl-Net-NBName.noarch: W: no-manual-page-for-binary namequery.pl
perl-Net-NBName.noarch: W: no-manual-page-for-binary nodescan.pl
perl-Net-NBName.noarch: W: no-manual-page-for-binary nodestat.pl
2 packages and 1 specfiles checked; 0 errors, 3 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm 
-rwxr-xr-x    1 root     root                      641 May 14 13:37 /usr/bin/namequery.pl
-rwxr-xr-x    1 root     root                      772 May 14 13:37 /usr/bin/nodescan.pl
-rwxr-xr-x    1 root     root                      309 May 14 13:37 /usr/bin/nodestat.pl
drwxr-xr-x    2 root     root                        0 May 14 13:37 /usr/share/doc/perl-Net-NBName
-rw-r--r--    1 root     root                     1836 May 14 13:37 /usr/share/doc/perl-Net-NBName/Changes
-rw-r--r--    1 root     root                      878 May 14 13:37 /usr/share/doc/perl-Net-NBName/README
-rw-r--r--    1 root     root                     4130 May 14 13:37 /usr/share/man/man3/Net::NBName.3pm.gz
-rw-r--r--    1 root     root                     1664 May 14 13:37 /usr/share/man/man3/Net::NBName::NameQuery.3pm.gz
-rw-r--r--    1 root     root                     1602 May 14 13:37 /usr/share/man/man3/Net::NBName::NameQuery::RR.3pm.gz
-rw-r--r--    1 root     root                     1544 May 14 13:37 /usr/share/man/man3/Net::NBName::NodeStatus.3pm.gz
-rw-r--r--    1 root     root                     1955 May 14 13:37 /usr/share/man/man3/Net::NBName::NodeStatus::RR.3pm.gz
drwxr-xr-x    2 root     root                        0 May 14 13:37 /usr/share/perl5/vendor_perl/Net
drwxr-xr-x    2 root     root                        0 May 14 13:37 /usr/share/perl5/vendor_perl/Net/NBName
-rw-r--r--    1 root     root                    13311 Jun 27  2006 /usr/share/perl5/vendor_perl/Net/NBName.pm
drwxr-xr-x    2 root     root                        0 May 14 13:37 /usr/share/perl5/vendor_perl/Net/NBName/NameQuery
-rw-r--r--    1 root     root                     2788 Jun 25  2006 /usr/share/perl5/vendor_perl/Net/NBName/NameQuery.pm
-rw-r--r--    1 root     root                     1851 Jun 25  2006 /usr/share/perl5/vendor_perl/Net/NBName/NameQuery/RR.pm
drwxr-xr-x    2 root     root                        0 May 14 13:37 /usr/share/perl5/vendor_perl/Net/NBName/NodeStatus
-rw-r--r--    1 root     root                     2163 Jun 25  2006 /usr/share/perl5/vendor_perl/Net/NBName/NodeStatus.pm
-rw-r--r--    1 root     root                     3418 Jun 25  2006 /usr/share/perl5/vendor_perl/Net/NBName/NodeStatus/RR.pm
File layout and permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(Net::NBName)
      1 perl(Net::NBName::NameQuery)
      1 perl(Net::NBName::NameQuery::RR)
      1 perl(Net::NBName::NodeStatus)
      1 perl(Net::NBName::NodeStatus::RR)
      1 perl(Net::Netmask)
      1 perl(Socket)
      1 perl(strict)
      1 perl(vars)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm | sort -f | uniq -c
      1 perl(Net::NBName) = 0.26
      1 perl(Net::NBName::NameQuery) = 0.26
      1 perl(Net::NBName::NameQuery::RR) = 0.26
      1 perl(Net::NBName::NodeStatus) = 0.26
      1 perl(Net::NBName::NodeStatus::RR) = 0.26
      1 perl(Net::NBName::Request)
      1 perl-Net-NBName = 0.26-41.fc35
Binary requires are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Net-NBName-0.26-41.fc35.noarch.rpm 
Binary dependencies are resolvable. Ok.

TODO: The package build fails to build in F35 (https://koji.fedoraproject.org/koji/taskinfo?taskID=67894236):
Processing files: perl-Net-NBName-0.26-41.fc35.noarch
error: File must begin with "/": %{perl_vendorlib}/Net

The package build in EPEL7 (https://koji.fedoraproject.org/koji/taskinfo?taskID=67894271) Ok.
The EPEL7 build is installable with EPEL7 repository. Ok.

The package is in line with EPEL7 packaging guidelines.
Please consider fixing the TODO items before building this package.
Resolution: Package APPROVED.
Comment 3 Fedora Update System 2021-05-26 22:54:49 UTC 
FEDORA-EPEL-2021-2c5040831f has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-2c5040831f
Comment 4 Fedora Update System 2021-05-27 01:14:23 UTC 
FEDORA-EPEL-2021-2c5040831f has been pushed to the Fedora EPEL 7 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2021-2c5040831f

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 5 Fedora Update System 2021-06-11 00:53:01 UTC 
FEDORA-EPEL-2021-2c5040831f has been pushed to the Fedora EPEL 7 stable repository.
If problem still persists, please make note of it in this bug report.