Bug 1952089

Summary: cloud-init brew build fails on Fedora 33
Product: Red Hat Enterprise Linux 8 Reporter: Emanuele Giuseppe Esposito <eesposit>
Component: cloud-initAssignee: Emanuele Giuseppe Esposito <eesposit>
Status: CLOSED ERRATA QA Contact: xiachen
Severity: low Docs Contact:
Priority: low    
Version: 8.5CC: eterrell, huzhao, jgreguske, ribarry, xiachen, xiaoxwan, yacao, yuxisun
Target Milestone: betaKeywords: Triaged, ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cloud-init-21.1-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1952092 1967600 (view as bug list) Environment:
Last Closed: 2021-11-09 18:48:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1952092, 1967600    

Description Emanuele Giuseppe Esposito 2021-04-21 13:27:42 UTC
Description of problem:
When issuing `make -C redhat/ rh-brew` on cloud-init repo using Fedora, I get the following error:

# make -C redhat/ rh-srpm
make: Entering directory '/home/esposem/Desktop/cloud-init/down/cloud-init/redhat'
Copying Sources: cloud-init-tmpfiles.conf gating.yaml
Using python3
error: The %systemd_postun macro requires some arguments
make: *** [Makefile:60: rh-srpm] Error 1


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1. clone red hat cloud-init repo on a Fedora machine
2. run make -C redhat/ rh-brew
3.

Actual results:
fails before uploading the srpm

Expected results:
brew task is issued and rpms are generated

Additional info:

The issue lays in redhat/cloud-init.spec.template, where it says 

%postun
%systemd_postun

which according to `man 7 daemon` is correct, since "%systemd_postun expects no arguments", but instead according with https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets it requires a parameter

Comment 1 Eduardo Otubo 2021-04-21 13:51:55 UTC
Curious to note that `man 7 daemon' on both RHEL or Fedora states that `"%systemd_postun" expects no arguments.'. Aut yet, on Fedora documentation[0] there's examples of usage of %systemd_postun *with* arguments. Since there's no instructions to it on our spec file, removing it should be harmless.

[0] https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/

Comment 21 errata-xmlrpc 2021-11-09 18:48:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cloud-init bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:4294