Bug 1952155

Summary:	Review Request: <python-automate-arduino> - <Arduino Support for Automate>
Product:	[Fedora] Fedora	Reporter:	Joe <joekim0923>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-21 20:21:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Joe 2021-04-21 16:02:08 UTC

Spec URL: 
https://raw.githubusercontent.com/Nycticoraci/FriendlyFedora/joe/python3/python-automate-arduino/automate-arduino.spec

SRPM URL: 
https://github.com/Nycticoraci/FriendlyFedora/blob/joe/python3/python-automate-arduino/python-automate-arduino-0.9.2-1.fc33.src.rpm?raw=true

Koji URL:
https://koji.fedoraproject.org/koji/taskinfo?taskID=66420395

Description: 
An extension that provides interfacing and support to Arduino microcontrollers via the pyFirmata library.

Source code is from the PyPi page, .spec file generated using pyp2rpm

Fedora Account System Username: joebkim

NOTE: I am in need of a sponsor.

Comment 1 Robert-André Mauchin 🐧 2021-04-21 20:21:49 UTC

Python 2 has been obsoleted since Fedora 32 and as such we do not accept new Python 2 packages.
See https://fedoraproject.org/wiki/Changes/RetirePython2

Don't let this stop you to contribute other packages to Fedora if you want!


The following review is informative only.


 - 

URL:            http://github.com/tuomas2/automate-arduino

→

URL:            https://github.com/tuomas2/automate-arduino

 - License is incorrect, it should be GPLv3

License:        GPLv3

 - This macro is not needed anymore:

%{?python_provide:%python_provide python2-%{pypi_name}}

 - You must install the license file with %license in %files:

%license LICENCE.txt
%doc README.rst