Bug 195255

Summary:	Review Request: manaworld - 2D mmorpg game
Product:	[Fedora] Fedora	Reporter:	Wart <wart>
Component:	Package Review	Assignee:	Hugo Cisneiros <hugo>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-06-14 16:25:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Wart 2006-06-14 16:22:58 UTC

Spec URL: http://www.kobold.org/~wart/fedora/manaworld.spec
SRPM URL: http://www.kobold.org/~wart/fedora/manaworld-0.0.19-1.src.rpm
Description: 

The Mana World (TMW) is a serious effort to create an innovative free and open
source MMORPG. TMW uses 2D graphics and aims to create a large and diverse
interactive world.

[Recreating the original review request due to recent bugzilla data loss]

Comment 1 Wart 2006-06-14 16:25:06 UTC

[reposting comments from original review]
------- Additional Comments From hugo.br  2006-06-11 21:08 EST -------
My Review:

MUST (OK)

 * rpmlint does not return any warning/errors (good)
 * Package is named according to Package Naming Guidelines
 * Spec filename matches package base name
 * Package license is open-source compliant
 * License field matches package's license
 * License file (COPYING) is included in %doc
 * Spec file is written in American English
 * Spec file is legible
 * Source file from package matches the upstream source with md5sum:
   b142f603c75819a04ac50d876776e92b  tmw-0.0.19.tar.gz
 * Package compiled and built fine in i386
 * BuildRequires is used well
 * Package does not contain locale files
 * Package does not contain shared library files
 * Package is not relocatable
 * Package owns all directories it creates
 * No duplicate files in %files
 * macro use consistent
 * No -doc subpackage needed
 * %doc contains only files that do not affect application runtime
 * No -devel subpackage needed
 * No pkgconfig files (.pc) needed
 * Package does not contain libtool archives (.la)
 * Desktop file installed with desktop-file-install
 * Package does not own other packages' directories

SHOULD (OK)

 * Scriptlets for icon cache are used in proper way
 * Package installs and runs just fine!


------- Additional Comments From hugo.br  2006-06-11 22:53 EST -------
APPROVED

------- Additional Comments From wart  2006-06-12 22:17 EST -------
Imported and built on FC-4, FC-5 (devel build queued)