Bug 1953253
| Summary: | Add "VM power state" filter to "Select VMs" page of "Migration plan" wizard | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Migration Toolkit for Virtualization | Reporter: | Nandini Chandra <nachandr> | ||||
| Component: | User Experience | Assignee: | vconzola | ||||
| Status: | CLOSED ERRATA | QA Contact: | Maayan Hadasi <mguetta> | ||||
| Severity: | medium | Docs Contact: | Avital Pinnick <apinnick> | ||||
| Priority: | medium | ||||||
| Version: | 2.0.0 | CC: | apinnick, fdupont, istein, jortel, mguetta, mturley, vconzola | ||||
| Target Milestone: | --- | Keywords: | RFE | ||||
| Target Release: | 2.2.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2021-12-09 19:20:45 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Nandini Chandra
2021-04-25 01:38:00 UTC
A powered off VM would still benefit from warm migration as it allows starting/stopping the VM during the precopy phase. This should be an RFE. @fdupont is this something we're adding for 2.1? This should be an RFE. @fdupont is this something we're adding for 2.1? It's indeed an RFE. Let's target it to 2.2 and get feedback on the warm migration feature first. After talking with @mturley we are going to add the power state everywhere in the UI that we display the VM name. Implementation thoughts: We display VM names in these 3 places: * In the table in the Select VMs step of the wizard * In the list of VMs on a plan page (VMMigrationDetails) * In the Plan Details modal, reachable from the actions kebab in the plans table (click on the number of VMs to see VM names in a popover) I think we should create a reusable <VMNameWithPowerState /> or some such, that takes a VM object and renders both the icon+tooltip and the name. That way we don't have to duplicate the power state icon logic in 3 places. Please verify with mtv-operator-bundle-2.2.0-43 / iib:123020, or later. Verified with mtv-operator-bundle-2.2.0-43 / iib:123020 UI displays 'Unknown power state' in the 3 places (described in comment #6) Moving back to ASSIGNED @mguetta Are you saying the power state is not being shown along with the VM name in the 3 places listed in comment 6? If so, please include screenshots, because this should be working now. Vince, @mguetta, Mike and I found the issue here. The power state properties of a VM are not part of the new detail level 1 (stripped-down payload), and we must have been developing this against an older version of the API. @jortel can we add those properties to the VM object in detail=1? (`status` for ovirt VMs, `powerState` for vsphere VMs) Created attachment 1834974 [details]
migration_plan_screenshot
Thanks Mike for confirming the issue. I also uploaded a screenshot
Fixed in MTV-2.2.0-57 Vince, Mike, in the description, it was mentioned that it would be great to be able to filter VMs by power state. The PR only adds the power state icon, but not a new filter criteria. How complex would that be? For posterity, the PR that fixed the Unknown Power State issue was https://github.com/konveyor/forklift-controller/pull/371. I can add the filter criteria fairly easily, will do so today and run it by Vince. Filter feature has been merged and backported, this is ready to test again. Verified with MTV 2.2.0-69 / iib:130005 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (MTV 2.2.0 Images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:5066 |