Bug 1953481

Summary:	New OCP priority classes are not used - Deploy
Product:	Container Native Virtualization (CNV)	Reporter:	Fabian Deutsch <fdeutsch>
Component:	Installation	Assignee:	Simone Tiraboschi <stirabos>
Status:	CLOSED ERRATA	QA Contact:	Satyajit Bulage <sbulage>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	2.6.0	CC:	cnv-qe-bugs, kmajcher, sbulage, stirabos
Target Milestone:	---	Flags:	sbulage: needinfo?
Target Release:	4.9.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	hco-bundle-registry-container-v4.9.0-43	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-02 15:57:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabian Deutsch 2021-04-26 08:36:34 UTC

Description of problem:
OCP has changed the names of priority classes. This component's _infrastructure pods_ priority classes should be added or adjusted accordingly to either system-cluster-critical or system-node-critical priority.

See https://mailman-int.corp.redhat.com/archives/aos-devel/2021-April/msg00402.html

The new classes must not be set on user workloads (i.e. VMs)

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
Infrastructure components should carry the new priority classes


Additional info:

Comment 2 Satyajit Bulage 2021-08-10 06:29:36 UTC

In the OpenShift Virtualization Operator I saw below changes:

----------------------------------------------------------------------------------
Virt-operator                    ==> priorityClassName: kubevirt-cluster-critical
Cluster-network-addons-operator  ==> priorityClassName: system-cluster-critical
Hyperconverged-cluster-operator  ==> priorityClassName: system-cluster-critical
Hyperconverged-cluster-webhook   ==> priorityClassName: system-node-critical
SSP-operator                     ==> priorityClassName: system-cluster-critical
----------------------------------------------------------------------------------

Also, I cross-checked the PR(attached to BZ) changes.

I have small question why/how 'virt-operator' has 'kubevirt-cluster-critical' priorityClass?

Comment 3 Fabian Deutsch 2021-08-11 13:33:31 UTC

That's a good question. @aschuett do you know?

Comment 4 aschuett 2021-08-11 13:40:51 UTC

We set the virt-operator's priority class in KubeVirt. We had a long discussion about changing the priority classes[1] but ultimately decided to keep the priority classes we already had assigned[2] which is the highest a user priority level can be set to. 

[1] https://github.com/kubevirt/kubevirt/pull/5901
[2] https://github.com/kubevirt/kubevirt/pull/5901#issuecomment-871321387

Comment 5 Satyajit Bulage 2021-08-13 04:24:34 UTC

Thanks Ashley :) for explanation.
Verifying the BZ.

Comment 9 errata-xmlrpc 2021-11-02 15:57:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.9.0 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4104