Bug 1953485

Summary:	[CNV-2.5] Manifests in openshift-cnv missing resource requirements - SSP
Product:	Container Native Virtualization (CNV)	Reporter:	Fabian Deutsch <fdeutsch>
Component:	SSP	Assignee:	Vatsal Parekh <vparekh>
Status:	CLOSED ERRATA	QA Contact:	Sarah Bennert <sbennert>
Severity:	high	Docs Contact:
Priority:	high
Version:	2.5.3	CC:	cnv-qe-bugs, dholler, ipinto, rnetser, sbennert, vparekh
Target Milestone:	---
Target Release:	4.8.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-21 11:06:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Fabian Deutsch 2021-04-26 08:45:21 UTC

This bug was initially created as a copy of Bug #1931519

I am copying this bug because: 



Description of problem:

Most of the deployments and daemonsets stored in the openshift-cnv namespace don't specify the resource request in their manifests. Only daemonset/kube-cni-linux-bridge-plugin, deployment/kubemacpool-mac-controller-manager and daemonset/kube-cni-linux-bridge-plugin have it defined as follows:


Kind       | Name                               | CPU Req/Limits | Mem Req/Limits
---------- | ---------------------------------- | -------------- | ---------------
daemonset  | kube-cni-linux-bridge-plugin       | 60m/0m         | 30Mi/0Mi
deployment | kubemacpool-mac-controller-manager | 100m/300m      | 300Mi/600Mi


The following list of manifests don't define the resource requirements:

Kind       | Name
---------- | ---- 
daemonset  | bridge-marker
daemonset  | nmstate-handler
daemonset  | ovs-cni-amd64
daemonset  | bridge-marker
daemonset  | nmstate-handler
daemonset  | ovs-cni-amd64
daemonset  | kubevirt-node-labeller
daemonset  | ovs-cni-amd64
daemonset  | nmstate-handler
deployment | cdi-uploadproxy
deployment | cdi-apiserver
deployment | nmstate-webhook
deployment | hostpath-provisioner-operator
deployment | virt-api
deployment | virt-controller
deployment | virt-handler
deployment | virt-operator
deployment | virt-template-validator
deployment | vm-import-controller
deployment | vm-import-operator
deployment | cdi-deployment
deployment | cluster-network-addons-operator
deployment | cdi-operator
deployment | cluster-network-addons-operator
deployment | kubevirt-ssp-operato
deployment | hco-operator


Version-Release number of selected component (if applicable):
CNV 2.5.3 and onward.

How reproducible:



Steps to Reproduce:
1.Create CNV namespace
2.Create CNV Operator Group
3.Create HCO subscription and deploy stable
4.Wait for deployment of HCO operator to complete
5.Check for resource requests in deployed manifests.

Actual results:
Only 2 deployed manifests define their resource requirements, and only 1 define the resource limits (see list above). 

Expected results:
All deployed manifests define the resource requirements.

Additional info:
N/A

Comment 1 Vatsal Parekh 2021-05-20 15:56:02 UTC

The PR got merged upstream

Comment 2 Sarah Bennert 2021-06-08 15:13:07 UTC

SSP Operator does not have the resources specified.

Cluster: 4.8.0-fc.7

registry.redhat.io/container-native-virtualization/hyperconverged-cluster-operator@sha256:efcdbf68f77c9ffe4ca051b0897df16ec153cfdd3989922c12810e7901c26150
v4.8.0-54

registry.redhat.io/container-native-virtualization/kubevirt-ssp-operator@sha256:daf9314c4a2fdba66b293b137d669d82b56c86b80fa0ac4f3f11cf4950d1d3ce
v4.8.0-36


DaemonSet bridge-marker {}
DaemonSet kube-cni-linux-bridge-plugin {"requests":{"cpu":"60m","memory":"30Mi"}}
DaemonSet nmstate-handler {}
DaemonSet virt-handler {"requests":{"cpu":"10m","memory":"230Mi"}}

Deployment cdi-apiserver {}
Deployment cdi-deployment {}
Deployment cdi-operator {}
Deployment cdi-uploadproxy {}
Deployment cluster-network-addons-operator {}
Deployment hco-operator {}
Deployment hco-webhook {}
Deployment hostpath-provisioner-operator {}
Deployment kubemacpool-cert-manager {}
Deployment kubemacpool-mac-controller-manager {"limits":{"cpu":"300m","memory":"600Mi"},"requests":{"cpu":"100m","memory":"300Mi"}}
Deployment nmstate-cert-manager {}
Deployment nmstate-webhook {}
Deployment node-maintenance-operator {}
Deployment ssp-operator {}
Deployment virt-api {"requests":{"cpu":"5m","memory":"150Mi"}}
Deployment virt-controller {"requests":{"cpu":"10m","memory":"150Mi"}}
Deployment virt-operator {"requests":{"cpu":"10m","memory":"150Mi"}}
Deployment virt-template-validator {"requests":{"cpu":"50m","memory":"150Mi"}}
Deployment vm-import-controller {}
Deployment vm-import-operator {}

Comment 4 Sarah Bennert 2021-08-18 12:17:37 UTC

ssp-operator missing resource requests

registry.redhat.io/container-native-virtualization/kubevirt-ssp-operator@sha256:443daad5d8b7dee15be68a64c8fb9e1cab0367ff4bb5c3e6831fa72349627783

Deployment ssp-operator {}

Comment 5 Dominik Holler 2021-08-19 13:10:19 UTC

Postpone to 4.8.2, to avoid risk in 4.8.1.

Comment 6 Vatsal Parekh 2021-08-30 10:14:28 UTC

Should be available in kubevirt-ssp-operator-container-v4.8.2-1

Comment 7 Ruth Netser 2021-08-30 12:46:53 UTC

Tested on SSP operator v4.8.2-1:


$ oc get deployment -n openshift-cnv virt-template-validator -o json | jq '.spec.template.spec.containers[].resources'
{
  "requests": {
    "cpu": "50m",
    "memory": "150Mi"
  }
}

$ oc get deployment -n openshift-cnv ssp-operator -o json | jq '.spec.template.spec.containers[].resources'
{
  "requests": {
    "cpu": "100m",
    "memory": "150Mi"
  }
}

Comment 8 Ruth Netser 2021-08-30 12:46:53 UTC

Tested on SSP operator v4.8.2-1:


$ oc get deployment -n openshift-cnv virt-template-validator -o json | jq '.spec.template.spec.containers[].resources'
{
  "requests": {
    "cpu": "50m",
    "memory": "150Mi"
  }
}

$ oc get deployment -n openshift-cnv ssp-operator -o json | jq '.spec.template.spec.containers[].resources'
{
  "requests": {
    "cpu": "100m",
    "memory": "150Mi"
  }
}

Comment 9 Ruth Netser 2021-08-30 12:49:50 UTC

(In reply to Ruth Netser from comment #8)
> Tested on CNV 4.8.2 (SSP operator v4.8.2-1) upgraded from CNV 4.8.1:
> 
> 
> $ oc get deployment -n openshift-cnv virt-template-validator -o json | jq
> '.spec.template.spec.containers[].resources'
> {
>   "requests": {
>     "cpu": "50m",
>     "memory": "150Mi"
>   }
> }
> 
> $ oc get deployment -n openshift-cnv ssp-operator -o json | jq
> '.spec.template.spec.containers[].resources'
> {
>   "requests": {
>     "cpu": "100m",
>     "memory": "150Mi"
>   }
> }

Moving to verified.

Comment 14 errata-xmlrpc 2021-09-21 11:06:44 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Virtualization 4.8.2 Images security and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3598