Bug 1953848 (CVE-2019-10743)

Summary: CVE-2019-10743 mholt/archiver: aribtrary file write via unsanitized destination filepaths
Product: [Other] Security Response Reporter: Sam Fowler <sfowler>
Component: vulnerabilityAssignee: Nobody <nobody>
Status: NEW --- QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: gparvin, jweiser, jwendell, rcernich, stcannon, thee, twalsh
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: mholt/archiver 3.3.2 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1953852    

Description Sam Fowler 2021-04-27 05:54:40 UTC 
All versions of archiver allow attacker to perform a Zip Slip attack via the "unarchive" functions. It is exploited using a specially crafted zip archive, that holds path traversal filenames. When exploited, a filename in a malicious archive is concatenated to the target extraction directory, which results in the final path ending up outside of the target folder. For instance, a zip may hold a file with a "../../file.exe" location and thus break out of the target folder. If an executable or a configuration file is overwritten with a file containing malicious code, the problem can turn into an arbitrary code execution issue quite easily. 


References:

https://github.com/mholt/archiver/pull/169
https://snyk.io/research/zip-slip-vulnerability
https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMMHOLTARCHIVERCMDARC-174728
Comment 1 Mark Cooper 2021-04-30 00:21:20 UTC 
Upstream fix: https://github.com/mholt/archiver/pull/169/commits/d818164a438603f1ba3fa952c7d99321f924301c
Comment 2 Mark Cooper 2021-04-30 00:32:20 UTC 
Whilst the snyk report says to update the version of github.com/mholt/archiver/cmd/arc to v3.3.2 

Looking at the patch:
https://github.com/mholt/archiver/commit/8217ed3a206c0473b4ec1aff51375b398838073a

Its the mhold/archiver/ library in general, as it looks like calling archiver.go:Unarchive can lead to the vulnerable code path. Also the patch itself doesn't apply to cmd/ but to the more general package files.
Comment 3 Mark Cooper 2021-04-30 00:34:24 UTC 
External References:

https://snyk.io/vuln/SNYK-GOLANG-GITHUBCOMMHOLTARCHIVERCMDARC-174728